From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932972AbcGOMOf (ORCPT ); Fri, 15 Jul 2016 08:14:35 -0400 Received: from mail-lf0-f48.google.com ([209.85.215.48]:34850 "EHLO mail-lf0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932764AbcGOMOc (ORCPT ); Fri, 15 Jul 2016 08:14:32 -0400 Date: Fri, 15 Jul 2016 14:14:35 +0200 From: Johan Hovold To: Mathieu OTHACEHE Cc: johan@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 25/36] usb: serial: ti_usb_3410_5052: Check old_termios parameter in set_termios Message-ID: <20160715121435.GO8809@localhost> References: <1463042948-12205-1-git-send-email-m.othacehe@gmail.com> <1463042948-12205-26-git-send-email-m.othacehe@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1463042948-12205-26-git-send-email-m.othacehe@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 12, 2016 at 10:48:57AM +0200, Mathieu OTHACEHE wrote: > The old_termios parameter is never used in set_termios callback. There we go. :) > Add a check to old_termios to see if we can return right away because > there is nothing to change. > Add a check to old_termios CBAUD to see if we can set DTR/RTS because > last speed was B0. Try splitting that up in two patches. > Also pass NULL for old_termios in open callback because it is the > initial call to set_termios. That's what you need to do of course (not change the prototype as I said earlier). Thanks, Johan