From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751486AbcGOMpX (ORCPT ); Fri, 15 Jul 2016 08:45:23 -0400 Received: from mail.skyhub.de ([78.46.96.112]:58037 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751220AbcGOMpT (ORCPT ); Fri, 15 Jul 2016 08:45:19 -0400 Date: Fri, 15 Jul 2016 14:45:23 +0200 From: Borislav Petkov To: Dave Young Cc: Andrew Morton , LKML , Franck Bui , Greg Kroah-Hartman , Ingo Molnar , Linus Torvalds , Peter Zijlstra , Steven Rostedt , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Subject: Re: [PATCH -v4 2/2] printk: Add kernel parameter to control writes to /dev/kmsg Message-ID: <20160715124523.GA26501@nazgul.tnic> References: <1467969530-5215-1-git-send-email-bp@alien8.de> <1467969530-5215-3-git-send-email-bp@alien8.de> <20160715062109.GA4515@dhcp-128-65.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160715062109.GA4515@dhcp-128-65.nay.redhat.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 15, 2016 at 02:21:09PM +0800, Dave Young wrote: > Sorry for jumping in late. But I just see this today and I really like the > idea to add a switch to turn off the kmsg writing from userspace because > I suffer from it also. Thanks, I'll send v5 soon. > I may missed the background, what is the reason for "ratelimit"? It sounds > a little odd. I think use default "on" should be safe to keep same behavior > as before. Yeah, so we want to ratelimit by default so that excessive logging doesn't disturb system operation. People who want to see all that blubber can do so with "on" so they should be taken care of too. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --