From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752794AbcGONKs (ORCPT ); Fri, 15 Jul 2016 09:10:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59902 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751609AbcGONJ4 (ORCPT ); Fri, 15 Jul 2016 09:09:56 -0400 Date: Fri, 15 Jul 2016 09:09:55 -0400 From: Vivek Goyal To: AKASHI Takahiro Cc: ebiederm@xmission.com, dyoung@redhat.com, bhe@redhat.com, bauerman@linux.vnet.ibm.com, arnd@arndb.de, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [RFC 3/3] kexec: extend kexec_file_load system call Message-ID: <20160715130955.GC23514@redhat.com> References: <20160712014201.11456-1-takahiro.akashi@linaro.org> <20160712014201.11456-4-takahiro.akashi@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160712014201.11456-4-takahiro.akashi@linaro.org> User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Fri, 15 Jul 2016 13:09:56 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 12, 2016 at 10:42:01AM +0900, AKASHI Takahiro wrote: [..] > -SYSCALL_DEFINE5(kexec_file_load, int, kernel_fd, int, initrd_fd, > +SYSCALL_DEFINE6(kexec_file_load, int, kernel_fd, int, initrd_fd, > unsigned long, cmdline_len, const char __user *, cmdline_ptr, > - unsigned long, flags) > + unsigned long, flags, const struct kexec_fdset __user *, ufdset) Can one add more parameters to existing syscall. Can it break existing programs with new kernel? I was of the impression that one can't do that. But may be I am missing something. Vivek