From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751254AbcGOPJL (ORCPT ); Fri, 15 Jul 2016 11:09:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39972 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751091AbcGOPJI (ORCPT ); Fri, 15 Jul 2016 11:09:08 -0400 Date: Fri, 15 Jul 2016 12:09:04 -0300 From: Arnaldo Carvalho de Melo To: Peter Zijlstra Cc: Stephen Rothwell , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: linux-next: build failure after merge of the luto-misc tree Message-ID: <20160715150903.GA2523@redhat.com> References: <20160715170654.0b09a8bc@canb.auug.org.au> <20160715072243.GP30154@twins.programming.kicks-ass.net> <20160715073119.GR30927@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160715073119.GR30927@twins.programming.kicks-ass.net> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.20 (2009-12-10) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 15 Jul 2016 15:09:08 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, Jul 15, 2016 at 09:31:19AM +0200, Peter Zijlstra escreveu: > On Fri, Jul 15, 2016 at 09:22:43AM +0200, Peter Zijlstra wrote: > > On Fri, Jul 15, 2016 at 05:06:54PM +1000, Stephen Rothwell wrote: > > > interacting with commit > > > > > > 2a00f026a15d ("tools: Fix up BITS_PER_LONG setting") > > > > > > from the tip tree. > > > > Yuck.. that thing is horrid :/ > > > > What's wrong with so? > > > > And if you really want to retain CONFIG_64BIT (because other headers > > might want it, and they currently do not) then do something like: > > > > #ifdef __LP64__ > > #define CONFIG_64BIT > > #else > > #define CONFIG_32BIT > > #endif > > > > All GCC versions I checked have __CHAR_BIT__ and __SIZEOF_LONG__. > > > > (and I checked most everything from 4.4 - 6.1) > > clang-3.8 also defines all three of those, and I don't consider that a > usable compiler as it doesn't even build a kernel. I was trying to have that file as close to the kernel as possible, but I'll try building with your patch in my test rig, lets see if one of the dozens of distros/releases barf at that... - Arnaldo