linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	Andy Lutomirski <luto@amacapital.net>,
	Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
	"H. Peter Anvin" <hpa@zytor.com>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Arnaldo Carvalho de Melo <acme@kernel.org>
Subject: Re: linux-next: build failure after merge of the luto-misc tree
Date: Fri, 15 Jul 2016 12:56:37 -0300	[thread overview]
Message-ID: <20160715155637.GD2523@redhat.com> (raw)
In-Reply-To: <20160715152937.GB3115@twins.programming.kicks-ass.net>

Em Fri, Jul 15, 2016 at 05:29:37PM +0200, Peter Zijlstra escreveu:
> On Fri, Jul 15, 2016 at 12:24:36PM -0300, Arnaldo Carvalho de Melo wrote:
> > Seems ok, but I'll reinstate this:
> > 
> > #if BITS_PER_LONG != __BITS_PER_LONG
> > #error Inconsistent word size. Check asm/bitsperlong.h
> > #endif
> 
> Confuses me; why do we have two?
> 
> Why not then do:
> 
> #define BITS_PER_LONG __BITS_PER_LONG
> 
> and be done with it?

Well, I just kept existing kernel practice, it uses __BITS_PER_LONG in
uapi files and BITS_PER_LONG elsewhere, since we copy stuff from the
kernel and check when it drifts using diff, I kept it like that so that
automation could point us when the tools/ copy drifted from the original
file.

- Arnaldo

  reply	other threads:[~2016-07-15 15:56 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-15  7:06 linux-next: build failure after merge of the luto-misc tree Stephen Rothwell
2016-07-15  7:22 ` Peter Zijlstra
2016-07-15  7:31   ` Peter Zijlstra
2016-07-15 15:09     ` Arnaldo Carvalho de Melo
2016-07-15 15:24       ` Arnaldo Carvalho de Melo
2016-07-15 15:29         ` Peter Zijlstra
2016-07-15 15:56           ` Arnaldo Carvalho de Melo [this message]
2016-07-15 15:43         ` [PATCH/RFC] " Arnaldo Carvalho de Melo
2016-07-15 15:49           ` Peter Zijlstra
2016-07-15 16:28             ` Arnaldo Carvalho de Melo
2016-07-15 20:26               ` H. Peter Anvin
2016-07-18  5:18           ` Stephen Rothwell
2016-07-18 20:04             ` Andy Lutomirski
2016-07-18 20:36               ` Arnaldo Carvalho de Melo
2016-07-18 22:22                 ` Stephen Rothwell
2016-07-18 23:41                   ` Arnaldo Carvalho de Melo
2016-07-19  0:26                     ` Stephen Rothwell
2016-07-19  0:39                       ` Arnaldo Carvalho de Melo
2016-07-19  3:26                         ` Stephen Rothwell
2016-07-19 12:54                           ` Arnaldo Carvalho de Melo
2016-07-19 17:45                             ` Arnaldo Carvalho de Melo
2016-07-19 23:21                               ` Stephen Rothwell
2016-07-19 23:53                                 ` Stephen Rothwell
2016-07-20  2:52                                   ` Arnaldo Carvalho de Melo
2016-07-20  2:57                                     ` Andy Lutomirski
2016-07-20  3:09                                       ` Arnaldo Carvalho de Melo
2016-07-20  3:18                                         ` Stephen Rothwell
2016-07-20 23:29                                     ` Stephen Rothwell
2016-07-21 13:12                                       ` Arnaldo Carvalho de Melo
2016-07-21 23:23                                         ` Stephen Rothwell
2016-07-22  3:41                                           ` Josh Poimboeuf
2016-07-22 14:37                                             ` Arnaldo Carvalho de Melo
2016-07-22 19:19                                               ` Josh Poimboeuf
2016-07-22 19:36                                                 ` Arnaldo Carvalho de Melo
2016-07-22 19:44                                                   ` Josh Poimboeuf
2016-07-22 19:57                                                     ` Arnaldo Carvalho de Melo
2016-07-23  5:08                                                       ` Stephen Rothwell
2016-07-24 18:40                                                         ` Andy Lutomirski
2016-07-25 12:56                                                         ` Arnaldo Carvalho de Melo
2016-07-25 18:12                                                         ` [tip:perf/core] x86: Make the vdso2c compiler use the host architecture headers tip-bot for Stephen Rothwell
2016-07-25 18:11                                                 ` [tip:perf/core] tools build: Fix objtool build with ARCH=x86_64 tip-bot for Josh Poimboeuf
2016-07-25 18:11                                             ` [tip:perf/core] objtool: Always use host headers tip-bot for Arnaldo Carvalho de Melo
2016-07-16 20:46   ` [tip:perf/core] tools: Simplify BITS_PER_LONG define tip-bot for Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160715155637.GD2523@redhat.com \
    --to=acme@redhat.com \
    --cc=acme@kernel.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=sfr@canb.auug.org.au \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).