public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrey Pronin <apronin@chromium.org>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: Peter Huewe <peterhuewe@gmx.de>,
	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
	Marcel Selhorst <tpmdd@selhorst.net>,
	tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
	groeck@chromium.org, smbarber@chromium.org,
	dianders@chromium.org
Subject: Re: [PATCH 0/2] tpm: add driver for cr50 on SPI
Date: Fri, 15 Jul 2016 10:15:57 -0700	[thread overview]
Message-ID: <20160715171557.GC109276@apronin> (raw)
In-Reply-To: <20160715032814.GG9347@obsidianresearch.com>

On Thu, Jul 14, 2016 at 09:28:14PM -0600, Jason Gunthorpe wrote:
> On Thu, Jul 14, 2016 at 07:50:26PM -0700, Andrey Pronin wrote:
> > Yes, it has a TCG-compliant interface, however, there are several things
> > specific to this device:
> >  - need to ensure a certain delay between spi transactions, or else
> >    the chip can miss several first bytes.
> >  - if there is no spi activity for this chip, it may go to sleep, and
> >    needs to be waken up before sending further commands.
> >  - it has some vendor-specific registers accessible from spi bus.
> 
> This all needs to be commented clearly in the driver..
> 

Will provide more details in the patch description. The driver code
has comments about those cases in the code: see cr50_ensure_access_delay
and cr50_needs_waking, for example.

  reply	other threads:[~2016-07-15 17:16 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-15  2:20 [PATCH 0/2] tpm: add driver for cr50 on SPI Andrey Pronin
2016-07-15  2:20 ` [PATCH 1/2] tpm: devicetree: document properties for cr50 Andrey Pronin
2016-07-15  4:05   ` Guenter Roeck
2016-07-15 17:31     ` Andrey Pronin
2016-07-15 18:28       ` Guenter Roeck
2016-07-17 13:28   ` Rob Herring
2016-07-15  2:20 ` [PATCH 2/2] tpm: add driver for cr50 on SPI Andrey Pronin
2016-07-15  3:32   ` Jason Gunthorpe
2016-07-15  3:44     ` Andrey Pronin
2016-07-19 12:55       ` Jarkko Sakkinen
2016-07-20  0:24         ` Andrey Pronin
2016-07-20 17:03           ` Jason Gunthorpe
2016-07-21 18:10             ` Andrey Pronin
2016-07-21 21:00               ` Jason Gunthorpe
2016-07-15  2:28 ` [PATCH 0/2] " Peter Huewe
2016-07-15  2:50   ` Andrey Pronin
2016-07-15  3:28     ` Jason Gunthorpe
2016-07-15 17:15       ` Andrey Pronin [this message]
2016-07-19 12:56 ` Jarkko Sakkinen
2016-07-20  3:41 ` [PATCH v2 " Andrey Pronin
2016-07-20  3:41   ` [PATCH v2 1/2] tpm: devicetree: document properties for cr50 Andrey Pronin
2016-07-20 19:03     ` Rob Herring
2016-07-20 19:49       ` Andrey Pronin
2016-07-20 19:54         ` Jason Gunthorpe
2016-07-27 21:02           ` Andrey Pronin
2016-07-21 21:03         ` Rob Herring
2016-07-27 21:00           ` Andrey Pronin
2016-07-20  3:41   ` [PATCH v2 2/2] tpm: add driver for cr50 on SPI Andrey Pronin
2016-07-25 17:09   ` Aw: [PATCH v2 0/2] " Peter Huewe
2016-07-27 21:12     ` Andrey Pronin
2016-07-28  4:25 ` [PATCH v3 " Andrey Pronin
2016-07-28  4:25 ` [PATCH v3 1/2] tpm: devicetree: document properties for cr50 Andrey Pronin
2016-07-28  4:25 ` [PATCH v3 2/2] tpm: add driver for cr50 on SPI Andrey Pronin
2016-07-28 23:01   ` Dmitry Torokhov
2016-07-28 23:17     ` Jason Gunthorpe
2016-07-29  3:01       ` Andrey Pronin
2016-07-29  1:55 ` [PATCH v4 0/2] " Andrey Pronin
2016-07-29  1:55 ` [PATCH v4 1/2] tpm: devicetree: document properties for cr50 Andrey Pronin
2016-07-29 17:27   ` Jason Gunthorpe
2016-07-29 21:42     ` Rob Herring
2016-08-09 10:08   ` Jarkko Sakkinen
2016-07-29  1:55 ` [PATCH v4 2/2] tpm: add driver for cr50 on SPI Andrey Pronin
2016-08-09 10:20   ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160715171557.GC109276@apronin \
    --to=apronin@chromium.org \
    --cc=dianders@chromium.org \
    --cc=groeck@chromium.org \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jgunthorpe@obsidianresearch.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterhuewe@gmx.de \
    --cc=smbarber@chromium.org \
    --cc=tpmdd-devel@lists.sourceforge.net \
    --cc=tpmdd@selhorst.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox