From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751622AbcGOSuR (ORCPT ); Fri, 15 Jul 2016 14:50:17 -0400 Received: from mail-pf0-f176.google.com ([209.85.192.176]:34627 "EHLO mail-pf0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751563AbcGOSuN (ORCPT ); Fri, 15 Jul 2016 14:50:13 -0400 Date: Fri, 15 Jul 2016 11:50:09 -0700 From: Bjorn Andersson To: Peter Chen Cc: lee.jones@linaro.org, linux-kernel@vger.kernel.org, Bjorn Andersson Subject: Re: [PATCH 1/1] mfd: qcom_rpm: add missing of_node_put after calling of_parse_phandle Message-ID: <20160715185009.GB13516@tuxbot> References: <1468575526-25074-1-git-send-email-peter.chen@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1468575526-25074-1-git-send-email-peter.chen@nxp.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 15 Jul 02:38 PDT 2016, Peter Chen wrote: > of_node_put needs to be called when the device node which is got > from of_parse_phandle has finished using. > > Cc: Bjorn Andersson Reviewed-by: Bjorn Andersson Regards, Bjorn > Cc: Lee Jones > Signed-off-by: Peter Chen > --- > drivers/mfd/qcom_rpm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mfd/qcom_rpm.c b/drivers/mfd/qcom_rpm.c > index 2e44323..ecca115 100644 > --- a/drivers/mfd/qcom_rpm.c > +++ b/drivers/mfd/qcom_rpm.c > @@ -538,6 +538,7 @@ static int qcom_rpm_probe(struct platform_device *pdev) > } > > rpm->ipc_regmap = syscon_node_to_regmap(syscon_np); > + of_node_put(syscon_np); > if (IS_ERR(rpm->ipc_regmap)) > return PTR_ERR(rpm->ipc_regmap); > > -- > 1.9.1 >