From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751512AbcGOVmR (ORCPT ); Fri, 15 Jul 2016 17:42:17 -0400 Received: from mga11.intel.com ([192.55.52.93]:40944 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750869AbcGOVmP (ORCPT ); Fri, 15 Jul 2016 17:42:15 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,369,1464678000"; d="scan'208";a="847175529" Date: Fri, 15 Jul 2016 15:42:13 -0600 From: Ross Zwisler To: Dan Carpenter Cc: Matthew Wilcox , Andrew Morton , Ross Zwisler , Konstantin Khlebnikov , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] testing/radix-tree: fix a macro expansion bug Message-ID: <20160715214213.GA3883@linux.intel.com> References: <20160715210953.GC19522@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160715210953.GC19522@mwanda> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 16, 2016 at 12:09:53AM +0300, Dan Carpenter wrote: > There are no parentheses around this macro and it causes a problem when > we do: > > index = rand() % THRASH_SIZE; > > Signed-off-by: Dan Carpenter Acked-by: Ross Zwisler > > diff --git a/tools/testing/radix-tree/tag_check.c b/tools/testing/radix-tree/tag_check.c > index b7447ce..b0ac057 100644 > --- a/tools/testing/radix-tree/tag_check.c > +++ b/tools/testing/radix-tree/tag_check.c > @@ -122,7 +122,7 @@ enum { > NODE_TAGGED = 2, > }; > > -#define THRASH_SIZE 1000 * 1000 > +#define THRASH_SIZE (1000 * 1000) > #define N 127 > #define BATCH 33 >