From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751882AbcGPAOr (ORCPT ); Fri, 15 Jul 2016 20:14:47 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:36711 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751626AbcGPAOp (ORCPT ); Fri, 15 Jul 2016 20:14:45 -0400 Date: Fri, 15 Jul 2016 17:14:42 -0700 From: Brian Norris To: weiyj_lk@163.com Cc: Boris Brezillon , Richard Weinberger , David Woodhouse , "Cooper Jr., Franklin" , Wei Yongjun , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] mtd: nand: omap2: fix return value check in omap_nand_probe() Message-ID: <20160716001442.GB76613@google.com> References: <1468498005-10664-1-git-send-email-weiyj_lk@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1468498005-10664-1-git-send-email-weiyj_lk@163.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 14, 2016 at 12:06:45PM +0000, weiyj_lk@163.com wrote: > From: Wei Yongjun > > In case of error, the function dma_request_chan() returns ERR_PTR() and > never returns NULL. The NULL test in the return value check should be > replaced with IS_ERR(). > > Fixes: aa7abd312c11 ('mtd: nand: omap2: Support parsing dma channel > information from DT') > Signed-off-by: Wei Yongjun Applied to l2-mtd.git