From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751380AbcGPDet (ORCPT ); Fri, 15 Jul 2016 23:34:49 -0400 Received: from mail-pa0-f65.google.com ([209.85.220.65]:32842 "EHLO mail-pa0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751217AbcGPDer (ORCPT ); Fri, 15 Jul 2016 23:34:47 -0400 Date: Sat, 16 Jul 2016 12:34:19 +0900 From: Sergey Senozhatsky To: Dan Carpenter Cc: Andrew Morton , Christoph Lameter , Sergey Senozhatsky , Colin Ian King , Laura Abbott , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] tools/vm/slabinfo: fix an unintentional printf Message-ID: <20160716033419.GA493@swordfish> References: <20160715211243.GE19522@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160715211243.GE19522@mwanda> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (07/16/16 00:12), Dan Carpenter wrote: > The curly braces are missing here so we print stuff unintentionally. > > Fixes: 9da4714a2d4f ('slub: slabinfo update for cmpxchg handling') Hello, a minor correction: it's 9da4714a2d44 not 9da4714a2d4f -ss > Signed-off-by: Dan Carpenter > > diff --git a/tools/vm/slabinfo.c b/tools/vm/slabinfo.c > index 7cf6e17..b9d34b3 100644 > --- a/tools/vm/slabinfo.c > +++ b/tools/vm/slabinfo.c > @@ -510,10 +510,11 @@ static void slab_stats(struct slabinfo *s) > s->alloc_node_mismatch, (s->alloc_node_mismatch * 100) / total); > } > > - if (s->cmpxchg_double_fail || s->cmpxchg_double_cpu_fail) > + if (s->cmpxchg_double_fail || s->cmpxchg_double_cpu_fail) { > printf("\nCmpxchg_double Looping\n------------------------\n"); > printf("Locked Cmpxchg Double redos %lu\nUnlocked Cmpxchg Double redos %lu\n", > s->cmpxchg_double_fail, s->cmpxchg_double_cpu_fail); > + } > } > > static void report(struct slabinfo *s) >