From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751440AbcGPFpp (ORCPT ); Sat, 16 Jul 2016 01:45:45 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:34173 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751017AbcGPFpn (ORCPT ); Sat, 16 Jul 2016 01:45:43 -0400 Date: Fri, 15 Jul 2016 22:45:39 -0700 From: Brian Norris To: Dan Carpenter Cc: David Woodhouse , Marc St-Jean , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] mtd: pmcmsp-flash: Allocating too much in init_msp_flash() Message-ID: <20160716054539.GA20393@google.com> References: <20160714104456.GG18175@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160714104456.GG18175@mwanda> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 14, 2016 at 01:44:56PM +0300, Dan Carpenter wrote: > There is a cut and paste issue here. The bug is that we are allocating > more memory than necessary for msp_maps. We should be allocating enough > space for a map_info struct (144 bytes) but we instead allocate enough > for an mtd_info struct (1840 bytes). It's a small waste. > > The other part of this is not harmful but when we allocated msp_flash > then we allocated enough space fro a map_info pointer instead of an > mtd_info pointer. But since pointers are the same size it works out > fine. > > Anyway, I decided to clean up all three allocations a bit to make them > a bit more consistent and clear. > > Fixes: 68aa0fa87f6d ('[MTD] PMC MSP71xx flash/rootfs mappings') > Signed-off-by: Dan Carpenter Applied to l2-mtd.git.