From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751738AbcGRCjc (ORCPT ); Sun, 17 Jul 2016 22:39:32 -0400 Received: from mail-pa0-f66.google.com ([209.85.220.66]:36157 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751383AbcGRCj2 (ORCPT ); Sun, 17 Jul 2016 22:39:28 -0400 Date: Mon, 18 Jul 2016 10:31:26 +0800 From: Peter Chen To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Richard Purdie , Jacek Anaszewski , Felipe Balbi , linux-usb@vger.kernel.org, Rob Herring , Mark Rutland , Jonathan Corbet , Sakari Ailus , Ezequiel Garcia , Boris Brezillon , Pavel Machek , Geert Uytterhoeven , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list , "open list:DOCUMENTATION" , "open list:LED SUBSYSTEM" Subject: Re: [PATCH V2] leds: trigger: Introduce an USB port trigger Message-ID: <20160718023126.GB31293@shlinux2> References: <1468239883-22695-1-git-send-email-zajec5@gmail.com> <1468617060-29830-1-git-send-email-zajec5@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1468617060-29830-1-git-send-email-zajec5@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 15, 2016 at 11:10:45PM +0200, Rafał Miłecki wrote: > + > +usbport trigger: > +- usb-ports : List of USB ports that usbport should observed for turning on a > + given LED. > + %s/should/should be > Examples: > > system-status { > @@ -58,6 +64,11 @@ system-status { > ... > }; > > +usb { > + label = "USB"; > + usb-ports = <&ohci_port1>, <&ehci_port1>; > +}; > + > camera-flash { > label = "Flash"; > led-sources = <0>, <1>; > diff --git a/Documentation/leds/ledtrig-usbport.txt b/Documentation/leds/ledtrig-usbport.txt > new file mode 100644 > index 0000000..642c4cd > --- /dev/null > +++ b/Documentation/leds/ledtrig-usbport.txt > @@ -0,0 +1,19 @@ > +USB port LED trigger > +==================== > + > +This LED trigger can be used for signaling user a presence of USB device in a > +given port. It simply turns on LED when device appears and turns it off when it > +disappears. > + > +It requires specifying a list of USB ports that should be observed. This can be > +done in DT by setting a proper property with list of a phandles. If more than > +one port is specified, LED will be turned on as along as there is at least one > +device connected to any of ports. > + > +This trigger can be activated from user space on led class devices as shown > +below: > + > + echo usbport > trigger > + > +Nevertheless, current there isn't a way to specify list of USB ports from user > +space. > diff --git a/drivers/leds/trigger/Kconfig b/drivers/leds/trigger/Kconfig > index 9893d91..5b8e7c7 100644 > --- a/drivers/leds/trigger/Kconfig > +++ b/drivers/leds/trigger/Kconfig > @@ -126,4 +126,12 @@ config LEDS_TRIGGER_PANIC > a different trigger. > If unsure, say Y. > > +config LEDS_TRIGGER_USBPORT > + tristate "USB port LED trigger" > + depends on LEDS_TRIGGERS && USB && OF > + help > + This allows LEDs to be controlled by USB events. This trigger will > + enable LED if some USB device gets connected to any of ports specified > + in DT. > + > endif # LEDS_TRIGGERS > diff --git a/drivers/leds/trigger/Makefile b/drivers/leds/trigger/Makefile > index 8cc64a4..80e2494 100644 > --- a/drivers/leds/trigger/Makefile > +++ b/drivers/leds/trigger/Makefile > @@ -10,3 +10,4 @@ obj-$(CONFIG_LEDS_TRIGGER_DEFAULT_ON) += ledtrig-default-on.o > obj-$(CONFIG_LEDS_TRIGGER_TRANSIENT) += ledtrig-transient.o > obj-$(CONFIG_LEDS_TRIGGER_CAMERA) += ledtrig-camera.o > obj-$(CONFIG_LEDS_TRIGGER_PANIC) += ledtrig-panic.o > +obj-$(CONFIG_LEDS_TRIGGER_USBPORT) += ledtrig-usbport.o > diff --git a/drivers/leds/trigger/ledtrig-usbport.c b/drivers/leds/trigger/ledtrig-usbport.c > new file mode 100644 > index 0000000..97b064c > --- /dev/null > +++ b/drivers/leds/trigger/ledtrig-usbport.c > @@ -0,0 +1,206 @@ > +/* > + * USB port LED trigger > + * > + * Copyright (C) 2016 Rafał Miłecki > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or (at > + * your option) any later version. > + */ GPL v2 only. > +MODULE_AUTHOR("Rafał Miłecki "); > +MODULE_DESCRIPTION("USB port trigger"); > +MODULE_LICENSE("GPL"); GPL v2 After you fix above, feel free to add: Reviewed-by: Peter Chen -- Best Regards, Peter Chen