From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751511AbcGRD1M (ORCPT ); Sun, 17 Jul 2016 23:27:12 -0400 Received: from LGEAMRELO11.lge.com ([156.147.23.51]:33811 "EHLO lgeamrelo11.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751391AbcGRD1K (ORCPT ); Sun, 17 Jul 2016 23:27:10 -0400 X-Original-SENDERIP: 156.147.1.121 X-Original-MAILFROM: byungchul.park@lge.com X-Original-SENDERIP: 10.177.222.33 X-Original-MAILFROM: byungchul.park@lge.com Date: Mon, 18 Jul 2016 12:25:10 +0900 From: Byungchul Park To: Frederic Weisbecker Cc: peterz@infradead.org, mingo@kernel.org, linux-kernel@vger.kernel.org, walken@google.com Subject: Re: [PATCH 1/2] x86/dumpstack: Optimize save_stack_trace Message-ID: <20160718032510.GO2279@X58A-UD3R> References: <1467628075-7289-1-git-send-email-byungchul.park@lge.com> <20160708144403.GG30200@lerouge> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160708144403.GG30200@lerouge> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 08, 2016 at 04:44:04PM +0200, Frederic Weisbecker wrote: > Nice improvement but how about doing that with the return value of > stacktrace_ops::address() instead? > > print_context_stack_bp() uses that for example. This behaviour could > be extended. Yes. I will leave the change in print_context_stack_bp() unchanged back. But frankly speaking, I thought the way to add end_walk improves its readibility. So I am not sure which way is better. Could you any guys give me additional opinions about the way to implement? I will follow it. Thank you, Byungchul