From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751522AbcGREoL (ORCPT ); Mon, 18 Jul 2016 00:44:11 -0400 Received: from mail.skyhub.de ([78.46.96.112]:50138 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751426AbcGREoD (ORCPT ); Mon, 18 Jul 2016 00:44:03 -0400 Date: Mon, 18 Jul 2016 06:44:07 +0200 From: Borislav Petkov To: Dave Young Cc: Andrew Morton , LKML , Franck Bui , Greg Kroah-Hartman , Ingo Molnar , Linus Torvalds , Peter Zijlstra , Steven Rostedt , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Subject: Re: [PATCH -v4 2/2] printk: Add kernel parameter to control writes to /dev/kmsg Message-ID: <20160718044407.GA20395@nazgul.tnic> References: <1467969530-5215-1-git-send-email-bp@alien8.de> <1467969530-5215-3-git-send-email-bp@alien8.de> <20160715062109.GA4515@dhcp-128-65.nay.redhat.com> <20160715124523.GA26501@nazgul.tnic> <20160716104425.GB3031@dhcp-128-65.nay.redhat.com> <20160717054035.GA16383@nazgul.tnic> <20160718021809.GA6310@dhcp-128-65.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160718021809.GA6310@dhcp-128-65.nay.redhat.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 18, 2016 at 10:18:09AM +0800, Dave Young wrote: > I would say avoiding ratelimit during boot make no much sense. Userspace can not > write to /dev/kmsg when system_state == SYSTEM_BOOTING because init process > has not run yet. You're right - kernel_init() sets SYSTEM_RUNNING before running the init process. I probably should kill all that logic in the second patch. > I means to set printk.devkmsg=off by default, userspace can set it to > on by sysctl. That can't happen: DEVKMSG_LOG_MASK_LOCK. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --