From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751764AbcGRGBv (ORCPT ); Mon, 18 Jul 2016 02:01:51 -0400 Received: from mail-pa0-f66.google.com ([209.85.220.66]:33695 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751678AbcGRGBs (ORCPT ); Mon, 18 Jul 2016 02:01:48 -0400 Date: Mon, 18 Jul 2016 13:53:45 +0800 From: Peter Chen To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Richard Purdie , Jacek Anaszewski , Felipe Balbi , "linux-usb@vger.kernel.org" , Rob Herring , Mark Rutland , Jonathan Corbet , Sakari Ailus , Ezequiel Garcia , Boris Brezillon , Pavel Machek , Geert Uytterhoeven , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list , "open list:DOCUMENTATION" , "open list:LED SUBSYSTEM" Subject: Re: [PATCH V2] leds: trigger: Introduce an USB port trigger Message-ID: <20160718055345.GF31293@shlinux2> References: <1468239883-22695-1-git-send-email-zajec5@gmail.com> <1468617060-29830-1-git-send-email-zajec5@gmail.com> <20160718023126.GB31293@shlinux2> <20160718054010.GE31293@shlinux2> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 18, 2016 at 07:57:34AM +0200, Rafał Miłecki wrote: > On 18 July 2016 at 07:40, Peter Chen wrote: > > On Mon, Jul 18, 2016 at 06:44:49AM +0200, Rafał Miłecki wrote: > >> On 18 July 2016 at 04:31, Peter Chen wrote: > >> > On Fri, Jul 15, 2016 at 11:10:45PM +0200, Rafał Miłecki wrote: > >> >> + > >> >> +usbport trigger: > >> >> +- usb-ports : List of USB ports that usbport should observed for turning on a > >> >> + given LED. > >> >> + > >> > > >> > %s/should/should be > >> > >> Thanks. > >> > >> > >> >> diff --git a/drivers/leds/trigger/ledtrig-usbport.c b/drivers/leds/trigger/ledtrig-usbport.c > >> >> new file mode 100644 > >> >> index 0000000..97b064c > >> >> --- /dev/null > >> >> +++ b/drivers/leds/trigger/ledtrig-usbport.c > >> >> @@ -0,0 +1,206 @@ > >> >> +/* > >> >> + * USB port LED trigger > >> >> + * > >> >> + * Copyright (C) 2016 Rafał Miłecki > >> >> + * > >> >> + * This program is free software; you can redistribute it and/or modify > >> >> + * it under the terms of the GNU General Public License as published by > >> >> + * the Free Software Foundation; either version 2 of the License, or (at > >> >> + * your option) any later version. > >> >> + */ > >> > In your COPYRIGHT, it says "or any later version". But afaik, It should not be on GPL v3. Peter > >> > GPL v2 only. > >> > > >> >> +MODULE_AUTHOR("Rafał Miłecki "); > >> >> +MODULE_DESCRIPTION("USB port trigger"); > >> >> +MODULE_LICENSE("GPL"); > >> > > >> > GPL v2 > >> > >> What's the reason for this? I don't have any real preference, but I > >> never heard heard about kernel/Linux preference neither. > >> > > > > https://en.wikipedia.org/wiki/Linux_kernel > > Well, Linux is released under GPL v2, I'm well aware of that. It means > all its code needs to be GPL v2 compatible. There are multiple > compatible licenses: MIT, BSD 3-clause, BSD 2-clause. The one I used > allows treating code as GPL V2 as well. I could release this code > using MIT and it should be acceptable as well. > > I still don't see what's wrong with the picked license. > > -- > Rafał -- Best Regards, Peter Chen