From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751802AbcGRIRV (ORCPT <rfc822;w@1wt.eu>);
	Mon, 18 Jul 2016 04:17:21 -0400
Received: from mx1.redhat.com ([209.132.183.28]:43954 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751426AbcGRIRT (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 18 Jul 2016 04:17:19 -0400
Date: Mon, 18 Jul 2016 16:17:12 +0800
From: Dave Young <dyoung@redhat.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>, Franck Bui <fbui@suse.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Ingo Molnar <mingo@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= 
	<u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH -v4 2/2] printk: Add kernel parameter to control writes
 to /dev/kmsg
Message-ID: <20160718081712.GA9239@dhcp-128-65.nay.redhat.com>
References: <20160715062109.GA4515@dhcp-128-65.nay.redhat.com>
 <20160715124523.GA26501@nazgul.tnic>
 <20160716104425.GB3031@dhcp-128-65.nay.redhat.com>
 <20160717054035.GA16383@nazgul.tnic>
 <20160718021809.GA6310@dhcp-128-65.nay.redhat.com>
 <20160718044407.GA20395@nazgul.tnic>
 <20160718052032.GA7911@dhcp-128-65.nay.redhat.com>
 <20160718072107.GA22689@nazgul.tnic>
 <20160718073845.GA9088@dhcp-128-65.nay.redhat.com>
 <20160718080846.GC22689@nazgul.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160718080846.GC22689@nazgul.tnic>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Mon, 18 Jul 2016 08:17:18 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 07/18/16 at 10:08am, Borislav Petkov wrote:
> On Mon, Jul 18, 2016 at 03:38:45PM +0800, Dave Young wrote:
> > no printk.devkmsg= on kernel cmdline
> >    -> unlocked, default is off, writing to /dev/kmsg is forbidded
> >       -> usespace set sysctl printk.devkmsg=on
> >          -> writing to /dev/kmsg is allowed.
> 
> And that helps how exactly?
> 
> I don't understand why you're harping on the ratelimiting. It is a sane
> default for the *default* case. Userspace should switch to its own
> logging scheme when it has started anyway.

Because IMHO it is wrong, they can not be ratelimited because the writing could
be from different userspace programs. Simply ratelimiting different sources of
writing is pointless to me. One can only see messages they would like to see
by luck, it is worse than off.

> 
> If you still want to see *all* messages, you boot with "=on" or set it
> through sysctl.
> 
> So what is the problem?!

As above mentioned..

Thanks
Dave