Re: [PATCH] bcache: untagle cache_aolloc

Johannes Thumshirn
2016-07-18T10:24:15Z

On Mon, Jul 18, 2016 at 02:13:33AM -0800, Kent Overstreet wrote:
> On Mon, Jul 18, 2016 at 12:11:09PM +0200, Johannes Thumshirn wrote:
> > bcache's cache_alloc() function currenty has no way freeing memory if one of
> > the allocations fails. Untangle the if + allocation statement so we have
> > defined checkpoints to free previous allocations if one fails.
>
> nack. The existing error path handles failure midway through just fine.

Come on, the patch improves the readability of the if statement by some orders
of magnitude as well.

Are you OK with it if I change the subject/commit log?

Johannes

--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850