From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751675AbcGRMOS (ORCPT <rfc822;w@1wt.eu>);
	Mon, 18 Jul 2016 08:14:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60732 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751398AbcGRMOP (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 18 Jul 2016 08:14:15 -0400
Date: Mon, 18 Jul 2016 14:14:09 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Jiri Pirko <jiri@mellanox.com>
Cc: Jiri Olsa <jolsa@kernel.org>, Arnaldo Carvalho de Melo <acme@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>, David Ahern <dsahern@gmail.com>,
        Ingo Molnar <mingo@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        "Steven Rostedt (Red Hat)" <rostedt@goodmis.org>
Subject: Re: [PATCH 3/3] perf tests: Add is_printable_array test
Message-ID: <20160718121409.GA4017@krava>
References: <1468685480-18951-1-git-send-email-jolsa@kernel.org>
 <1468685480-18951-4-git-send-email-jolsa@kernel.org>
 <20160718114602.GK2075@nanopsycho.orion>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160718114602.GK2075@nanopsycho.orion>
User-Agent: Mutt/1.6.2 (2016-07-01)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 18 Jul 2016 12:14:15 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jul 18, 2016 at 01:46:02PM +0200, Jiri Pirko wrote:

SNIP

> >diff --git a/tools/perf/tests/is_printable_array.c b/tools/perf/tests/is_printable_array.c
> >new file mode 100644
> >index 000000000000..42e13393e502
> >--- /dev/null
> >+++ b/tools/perf/tests/is_printable_array.c
> >@@ -0,0 +1,36 @@
> >+#include <linux/compiler.h>
> >+#include "tests.h"
> >+#include "debug.h"
> >+#include "util.h"
> >+
> >+int test__is_printable_array(int subtest __maybe_unused)
> >+{
> >+	char buf1[] = { 'k', 'r', 4, 'v', 'a', 0 };
> >+	char buf2[] = { 'k', 'r', 'a', 'v', 4, 0 };
> >+	struct {
> >+		char		*buf;
> >+		unsigned int	 len;
> >+		int		 ret;
> >+	} t[] = {
> >+		{ (char *) "krava",	sizeof("krava"),	1 },
> >+		{ (char *) "krava",	sizeof("krava") - 1,	0 },
> 
> "a cow" ? Really? :))

yea, trying to force it as 'perf animal' instead of that pony stuff ;-)

http://www.brendangregg.com/blog/2015-07-08/choosing-a-linux-tracer.html

jirka