From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751789AbcGRNYg (ORCPT <rfc822;w@1wt.eu>);
	Mon, 18 Jul 2016 09:24:36 -0400
Received: from mail-wm0-f51.google.com ([74.125.82.51]:34691 "EHLO
	mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750732AbcGRNYd (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 18 Jul 2016 09:24:33 -0400
Date: Mon, 18 Jul 2016 14:25:40 +0100
From: Lee Jones <lee.jones@linaro.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        rklein@nvidia.com, linus.walleij@linaro.org
Subject: Re: [PATCH 1/3] mfd: Provide MACRO to declare commonly defined MFD
 cell attributes
Message-ID: <20160718132540.GC17074@dell>
References: <20160713112651.14539-1-lee.jones@linaro.org>
 <20160713112651.14539-2-lee.jones@linaro.org>
 <5788E093.7080405@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <5788E093.7080405@nvidia.com>
User-Agent: Mutt/1.6.2 (2016-07-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 15 Jul 2016, Laxman Dewangan wrote:

> 
> On Wednesday 13 July 2016 04:56 PM, Lee Jones wrote:
> > Cc: Laxman Dewangan <ldewangan@nvidia.com>
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> >   include/linux/mfd/core.h | 29 +++++++++++++++++++++++++++++
> >   1 file changed, 29 insertions(+)
> > 
> > diff --git a/include/linux/mfd/core.h b/include/linux/mfd/core.h
> > index 99c0395..c6018f4 100644
> > --- a/include/linux/mfd/core.h
> > +++ b/include/linux/mfd/core.h
> > @@ -16,6 +16,35 @@
> >   #include <linux/platform_device.h>
> 
> > +#define MFD_CELL_BASIC(_name, _res, _pdata, _pdsize, _id)		\
> > +	MFD_CELL_ALL(_name, _res, _pdata, _pdsize, _id, NULL, NULL)	\
> > +
> > +#define MFD_CELL_RES(_name, _res)					\
> > +	MFD_CELL_ALL(_name, _res, _pdata, 0, 0, NULL, NULL)		\
> > +
> Here _pdata should not be used. Instead it should be NULL.

Yes, it should.  Thanks for the review.

> I corrected it locally and then compiled and teste.

Wonderful, thanks.

> Once above fixed, you can take my ack and tested by
> 
> Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
> Tested-by: Laxman Dewangan <ldewangan@nvidia.com>
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog