From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751567AbcGROID (ORCPT <rfc822;w@1wt.eu>);
	Mon, 18 Jul 2016 10:08:03 -0400
Received: from mx1.redhat.com ([209.132.183.28]:46034 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751232AbcGROH7 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 18 Jul 2016 10:07:59 -0400
Date: Mon, 18 Jul 2016 16:07:54 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Song Shan Gong <gongss@linux.vnet.ibm.com>
Cc: acme@kernel.org, jolsa@kernel.org, dsahern@gmail.com,
        linux-kernel@vger.kernel.org, borntraeger@de.ibm.com
Subject: Re: [RFC PATCH V2] s390/perf: fix 'start' address of module's map
Message-ID: <20160718140754.GA9555@krava>
References: <1468577711-6622-1-git-send-email-gongss@linux.vnet.ibm.com>
 <1468577711-6622-2-git-send-email-gongss@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1468577711-6622-2-git-send-email-gongss@linux.vnet.ibm.com>
User-Agent: Mutt/1.6.2 (2016-07-01)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 18 Jul 2016 14:07:58 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jul 15, 2016 at 06:15:11PM +0800, Song Shan Gong wrote:
> At preset, when creating module's map, perf gets 'start' address by parsing
> '/proc/modules', but it's module base address, isn't the start address of
> '.text' section. In most archs, it's OK. But for s390, it places 'GOT' and
> 'PLT' relocations before '.text' section. So there exists an offset between
> module base address and '.text' section, which will incur wrong symbol
> resolution for modules.
> 
> Fix this bug by getting 'start' address of module's map from parsing
> '/sys/module/[module name]/sections/.text', not from '/proc/modules'.
> 
> Signed-off-by: Song Shan Gong <gongss@linux.vnet.ibm.com>
> ---
>  tools/perf/arch/s390/util/Build          |  2 ++
>  tools/perf/arch/s390/util/sym-handling.c | 27 +++++++++++++++++++++++++++
>  tools/perf/util/machine.c                |  8 ++++++++
>  tools/perf/util/machine.h                |  1 +
>  4 files changed, 38 insertions(+)
>  create mode 100644 tools/perf/arch/s390/util/sym-handling.c
> 
> diff --git a/tools/perf/arch/s390/util/Build b/tools/perf/arch/s390/util/Build
> index 8a61372..5e322ed 100644
> --- a/tools/perf/arch/s390/util/Build
> +++ b/tools/perf/arch/s390/util/Build
> @@ -2,3 +2,5 @@ libperf-y += header.o
>  libperf-y += kvm-stat.o
>  
>  libperf-$(CONFIG_DWARF) += dwarf-regs.o
> +
> +libperf-y += sym-handling.o
> diff --git a/tools/perf/arch/s390/util/sym-handling.c b/tools/perf/arch/s390/util/sym-handling.c
> new file mode 100644
> index 0000000..ff51336
> --- /dev/null
> +++ b/tools/perf/arch/s390/util/sym-handling.c
> @@ -0,0 +1,27 @@
> +#include <stdio.h>
> +#include <stdlib.h>
> +#include <unistd.h>
> +#include "util.h"
> +#include "machine.h"
> +#include "api/fs/fs.h"
> +
> +int arch__fix_module_text_start(u64 *start, const char *name)
> +{
> +	char path[PATH_MAX];
> +	char *module_name = NULL;
> +	int len;
> +
> +	if (!(module_name = strdup(name)))
> +		return -1;
> +
> +	len = strlen(module_name);
> +	module_name[len - 1] = '\0';
> +	snprintf(path, PATH_MAX, "module/%s/sections/.text",
> +				module_name + 1);

why can't you use 'name' in here? I can't see the reason
you allocated module_name..

> +
> +	if (sysfs__read_ull(path, (unsigned long long *)start) < 0) {
> +		free(module_name);
> +		return -1;
> +	}

leaking module_name in here

> +	return 0;
> +}

SNIP

thanks,
jirka