From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752543AbcGROdJ (ORCPT ); Mon, 18 Jul 2016 10:33:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58601 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751973AbcGROdF (ORCPT ); Mon, 18 Jul 2016 10:33:05 -0400 Date: Mon, 18 Jul 2016 16:32:59 +0200 From: Jiri Olsa To: Mark Rutland Cc: linux-kernel@vger.kernel.org, acme@kernel.org, adrian.hunter@intel.com, alexander.shishkin@linux.intel.com, hekuang@huawei.com, jolsa@kernel.org, kan.liang@intel.com, mingo@redhat.com, peterz@infradead.org, wangnan0@huawei.com Subject: Re: [RFCv2 3/4] perf: util: only open events on CPUs an evsel permits Message-ID: <20160718143259.GD4813@krava> References: <1468577293-19667-1-git-send-email-mark.rutland@arm.com> <1468577293-19667-4-git-send-email-mark.rutland@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1468577293-19667-4-git-send-email-mark.rutland@arm.com> User-Agent: Mutt/1.6.2 (2016-07-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Mon, 18 Jul 2016 14:33:04 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 15, 2016 at 11:08:12AM +0100, Mark Rutland wrote: > In systems with heterogeneous CPU PMUs, it's possible for each evsel to > cover a distinct set of CPUs, and hence the cpu_map associated with each > evsel may have a distinct idx<->id mapping. Any of these may be distinct from > the evlist's cpu map. > > Events can be tied to the same fd so long as they use the same per-cpu > ringbuffer (i.e. so long as they are on the same CPU). To acquire the > correct FDs, we must compare the Linux logical IDs rather than the evsel > or evlist indices. > > This path adds logic to perf_evlist__mmap_per_evsel to handle this, > translating IDs as required. As PMUs may cover a subset of CPUs from the > evlist, we skip the CPUs a PMU cannot handle. > > Signed-off-by: Mark Rutland > Cc: Adrian Hunter > Cc: Alexander Shishkin > Cc: Arnaldo Carvalho de Melo > Cc: He Kuang > Cc: Ingo Molnar > Cc: Jiri Olsa > Cc: Peter Zijlstra > Cc: Wang Nan > Cc: linux-kernel@vger.kernel.org Acked-by: Jiri Olsa thanks, jirka > --- > tools/perf/util/evlist.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c > index e82ba90..ef56b7f 100644 > --- a/tools/perf/util/evlist.c > +++ b/tools/perf/util/evlist.c > @@ -984,17 +984,23 @@ static int __perf_evlist__mmap(struct perf_evlist *evlist, int idx, > } > > static int perf_evlist__mmap_per_evsel(struct perf_evlist *evlist, int idx, > - struct mmap_params *mp, int cpu, > + struct mmap_params *mp, int cpu_idx, > int thread, int *output) > { > struct perf_evsel *evsel; > + int evlist_cpu = cpu_map__cpu(evlist->cpus, cpu_idx); > > evlist__for_each(evlist, evsel) { > int fd; > + int cpu; > > if (evsel->system_wide && thread) > continue; > > + cpu = cpu_map__idx(evsel->cpus, evlist_cpu); > + if (cpu == -1) > + continue; > + > fd = FD(evsel, cpu, thread); > > if (*output == -1) { > -- > 1.9.1 >