From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751908AbcGRQLp (ORCPT ); Mon, 18 Jul 2016 12:11:45 -0400 Received: from gum.cmpxchg.org ([85.214.110.215]:53234 "EHLO gum.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751773AbcGRQLo (ORCPT ); Mon, 18 Jul 2016 12:11:44 -0400 Date: Mon, 18 Jul 2016 12:11:28 -0400 From: Johannes Weiner To: Mel Gorman Cc: Andrew Morton , Minchan Kim , Vlastimil Babka , Linux-MM , LKML Subject: Re: [PATCH 1/3] mm, vmscan: Remove redundant check in shrink_zones() Message-ID: <20160718161128.GA16465@cmpxchg.org> References: <1468853426-12858-1-git-send-email-mgorman@techsingularity.net> <1468853426-12858-2-git-send-email-mgorman@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1468853426-12858-2-git-send-email-mgorman@techsingularity.net> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 18, 2016 at 03:50:24PM +0100, Mel Gorman wrote: > As pointed out by Minchan Kim, shrink_zones() checks for populated > zones in a zonelist but a zonelist can never contain unpopulated > zones. While it's not related to the node-lru series, it can be > cleaned up now. > > Suggested-by: Minchan Kim > Signed-off-by: Mel Gorman Ha, I didn't know that. But yeah, the zonelist building code excludes unpopulated zones from the start. Neat. Acked-by: Johannes Weiner