From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751538AbcGRRJg (ORCPT ); Mon, 18 Jul 2016 13:09:36 -0400 Received: from mx2.suse.de ([195.135.220.15]:58329 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750732AbcGRRJe (ORCPT ); Mon, 18 Jul 2016 13:09:34 -0400 Date: Mon, 18 Jul 2016 19:09:30 +0200 From: Jean Delvare To: Allen Hung Cc: linux-kernel@vger.kernel.org, Mario Limonciello Subject: Re: [PATCH 1/2] dmi-id: don't free dev structure after calling device_register Message-ID: <20160718190930.1c270ec9@endymion> In-Reply-To: <1468483283-84766-2-git-send-email-allen_hung@dell.com> References: <1468483283-84766-1-git-send-email-allen_hung@dell.com> <1468483283-84766-2-git-send-email-allen_hung@dell.com> Organization: SUSE Linux X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.30; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 14 Jul 2016 16:01:22 +0800, Allen Hung wrote: > dmi_dev is freed in error exit code but, according to the document > of device_register, it should never directly free device structure > after calling this function, even if it returned an error! Use > put_device() instead. > > Signed-off-by: Allen Hung > --- > drivers/firmware/dmi-id.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/firmware/dmi-id.c b/drivers/firmware/dmi-id.c > index 94a58a0..44c0139 100644 > --- a/drivers/firmware/dmi-id.c > +++ b/drivers/firmware/dmi-id.c > @@ -229,14 +229,14 @@ static int __init dmi_id_init(void) > > ret = device_register(dmi_dev); > if (ret) > - goto fail_free_dmi_dev; > + goto fail_put_dmi_dev; > > return 0; > > -fail_free_dmi_dev: > - kfree(dmi_dev); > -fail_class_unregister: > +fail_put_dmi_dev: > + put_device(dmi_dev); > > +fail_class_unregister: > class_unregister(&dmi_class); > > return ret; Good catch. Applied, thanks. -- Jean Delvare SUSE L3 Support