From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752485AbcGRTni (ORCPT ); Mon, 18 Jul 2016 15:43:38 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:33379 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752180AbcGRTne (ORCPT ); Mon, 18 Jul 2016 15:43:34 -0400 Date: Mon, 18 Jul 2016 12:43:31 -0700 From: Alison Schofield To: Jonathan Cameron Cc: Matt Ranostay , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] iio: humidity: hdc100x: add HDC1000 and HDC1008 product names Message-ID: <20160718194330.GA3870@d830.WORKGROUP> References: <20160520170500.GA2620@d830.WORKGROUP> <446b3713-c613-34c9-4432-1bafa8cd0579@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <446b3713-c613-34c9-4432-1bafa8cd0579@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 21, 2016 at 05:27:16PM +0100, Jonathan Cameron wrote: > On 20/05/16 18:34, Matt Ranostay wrote: > > On Fri, May 20, 2016 at 10:05 AM, Alison Schofield wrote: > >> hdc100x supports Texas Instruments HDC1000 and HDC1008 relative > >> humidity and temperature sensors. Add these product names to > >> Kconfig and to the drivers device id structure to enable finding > >> the product by name and using it to add a device. > >> > >> Signed-off-by: Alison Schofield > >> Cc: Daniel Baluta > >> --- > >> drivers/iio/humidity/Kconfig | 8 ++++---- > >> drivers/iio/humidity/hdc100x.c | 2 ++ > >> 2 files changed, 6 insertions(+), 4 deletions(-) > >> > >> diff --git a/drivers/iio/humidity/Kconfig b/drivers/iio/humidity/Kconfig > >> index 738a86d..f155386 100644 > >> --- a/drivers/iio/humidity/Kconfig > >> +++ b/drivers/iio/humidity/Kconfig > >> @@ -26,11 +26,11 @@ config HDC100X > >> tristate "TI HDC100x relative humidity and temperature sensor" > >> depends on I2C > >> help > >> - Say yes here to build support for the TI HDC100x series of > >> - relative humidity and temperature sensors. > >> + Say yes here to build support for the Texas Instruments > >> + HDC1000 and HDC1008 relative humidity and temperature sensors. > >> > >> - To compile this driver as a module, choose M here: the module > >> - will be called hdc100x. > >> + To compile this driver as a module, choose M here: the module > >> + will be called hdc100x. > >> > >> config HTU21 > >> tristate "Measurement Specialties HTU21 humidity & temperature sensor" > >> diff --git a/drivers/iio/humidity/hdc100x.c b/drivers/iio/humidity/hdc100x.c > >> index fa47676..0deb874 100644 > >> --- a/drivers/iio/humidity/hdc100x.c > >> +++ b/drivers/iio/humidity/hdc100x.c > >> @@ -302,6 +302,8 @@ static int hdc100x_probe(struct i2c_client *client, > >> > >> static const struct i2c_device_id hdc100x_id[] = { > >> { "hdc100x", 0 }, > >> + { "hdc1000", 0 }, > >> + { "hdc1008", 0 }, > > > > Personally I think adding more device ids that don't add any per chip > > configuration is just adding clutter. > > There is a reason I used "hdc100x" when I wrote the driver :) > Hmm. I should have picked up on this in the first place. It's much preferred to > go with complete part names. Avoids any possible issues with devicetrees / ACPI > bindings where it's kind of assumed a whole part name will be used. > > I'd prefer to have them explicitly listed. We will have to keep the wild card > form as well as by now there will be boards using that out there. > If it was just internal to the kernel I'd agree with the clutter argument, but > it isn't so let us be as explicit in the naming as possible. > > Jonathan Jonathan, It seemed like you were going to take this patch, but haven't. I can pull the names out of the device_id fields if wanted, but it would be nice to at least have them in the Kconfig so one can grep for these names. Let me know if it needs a v2. Thanks, alisons > > > > > >> { } > >> }; > >> MODULE_DEVICE_TABLE(i2c, hdc100x_id); > >> -- > >> 2.1.4 > >> >