Re: [PATCH v2 net-next v2 03/12] net: dsa: mv88e6xxx: extract device mapping

Andrew Lunn
2016-07-18T19:36:03Z

> +/* Indirect write to single pointer-data register with an Update bit */
> +static int mv88e6xxx_update_write(struct mv88e6xxx_chip *chip,
> + int addr, int reg, u16 update)

Hi Vivien

I don't think mv88e6xxx_update_read() makes any sense? Can we just
infer write? Call it mv88e6xxx_update().

> +static int mv88e6xxx_g2_device_mapping_write(struct mv88e6xxx_chip *chip,
> + int target, int port)
> +{
> + u16 val = (target << 8) | (port & 0xf);
> +
> + return mv88e6xxx_update_write(chip, REG_GLOBAL2, GLOBAL2_DEVICE_MAPPING,
> + val);

This would then all be on one line and look a better.

Andrew