From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752072AbcGRWqL (ORCPT ); Mon, 18 Jul 2016 18:46:11 -0400 Received: from mail.kernel.org ([198.145.29.136]:42660 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751936AbcGRWqJ (ORCPT ); Mon, 18 Jul 2016 18:46:09 -0400 Date: Mon, 18 Jul 2016 19:46:04 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Mark Rutland , linux-kernel@vger.kernel.org, adrian.hunter@intel.com, alexander.shishkin@linux.intel.com, hekuang@huawei.com, jolsa@kernel.org, kan.liang@intel.com, mingo@redhat.com, peterz@infradead.org, wangnan0@huawei.com Subject: Re: [RFCv2 3/4] perf: util: only open events on CPUs an evsel permits Message-ID: <20160718224604.GG2207@kernel.org> References: <1468577293-19667-1-git-send-email-mark.rutland@arm.com> <1468577293-19667-4-git-send-email-mark.rutland@arm.com> <20160718143259.GD4813@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160718143259.GD4813@krava> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Jul 18, 2016 at 04:32:59PM +0200, Jiri Olsa escreveu: > On Fri, Jul 15, 2016 at 11:08:12AM +0100, Mark Rutland wrote: > > In systems with heterogeneous CPU PMUs, it's possible for each evsel to > > cover a distinct set of CPUs, and hence the cpu_map associated with each > > evsel may have a distinct idx<->id mapping. Any of these may be distinct from > > the evlist's cpu map. > > > > Events can be tied to the same fd so long as they use the same per-cpu > > ringbuffer (i.e. so long as they are on the same CPU). To acquire the > > correct FDs, we must compare the Linux logical IDs rather than the evsel > > or evlist indices. > > > > This path adds logic to perf_evlist__mmap_per_evsel to handle this, > > translating IDs as required. As PMUs may cover a subset of CPUs from the > > evlist, we skip the CPUs a PMU cannot handle. > > > > Signed-off-by: Mark Rutland > > Cc: Adrian Hunter > > Cc: Alexander Shishkin > > Cc: Arnaldo Carvalho de Melo > > Cc: He Kuang > > Cc: Ingo Molnar > > Cc: Jiri Olsa > > Cc: Peter Zijlstra > > Cc: Wang Nan > > Cc: linux-kernel@vger.kernel.org > > Acked-by: Jiri Olsa Applied the first two, this one is not applying, please check my perf/core branch, what is there should soon be pushed to Ingo, so tip/perf/core may be ok too. - Arnaldo