From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752493AbcGSAs1 (ORCPT ); Mon, 18 Jul 2016 20:48:27 -0400 Received: from mail-pa0-f66.google.com ([209.85.220.66]:32872 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752174AbcGSAsY (ORCPT ); Mon, 18 Jul 2016 20:48:24 -0400 Date: Mon, 18 Jul 2016 20:48:21 -0400 From: Tejun Heo To: Bhaktipriya Shridhar Cc: Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] drm/radeon: Remove deprecated create_singlethread_workqueue Message-ID: <20160719004821.GD3078@mtj.duckdns.org> References: <20160712175252.GN3190@htj.duckdns.org> <20160716113044.GA18061@Karyakshetra> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160716113044.GA18061@Karyakshetra> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 16, 2016 at 05:00:44PM +0530, Bhaktipriya Shridhar wrote: > > alloc_workqueue replaces deprecated create_singlethread_workqueue(). > > Each hardware CRTC has a single flip work queue. > When a radeon_flip_work_func item is queued, it needs to be executed > ASAP because even a slight delay may cause the flip to be delayed by > one refresh cycle. > > Hence, a dedicated workqueue with WQ_HIGHPRI set, has been used here > since a delay can cause the outcome to miss the refresh cycle. > > Since there are only a fixed number of work items, explicit concurrency > limit is unnecessary here. > > Signed-off-by: Bhaktipriya Shridhar Acked-by: Tejun Heo Thanks. -- tejun