public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] ESIA : Dummy eisa_driver_register should return error code
Date: Mon, 18 Jul 2016 21:31:52 -0700	[thread overview]
Message-ID: <20160719043152.GA27579@infradead.org> (raw)
In-Reply-To: <1468867501-19054-1-git-send-email-arvind.yadav.cs@gmail.com>

On Tue, Jul 19, 2016 at 12:15:01AM +0530, Arvind Yadav wrote:
> The inline eisa_driver_register stub simply allows compilation on
> systems with CONFIG_EISA disabled. the dummy eisa_driver_register
> does not register an *_eisa_driver at all. The inline
> eisa_driver_register should return to indicate lack of support
> when attempting to register an *_eisa_driver on such a system with
> CONFIG_EISA disabled.

Why?  The idea is that you can simply leave the stub in if registering
say PCI / EISA.  With your change such a driver will fail to load even
if it could serve PCI device in a !CONFIG_EISA config, which is the
behavior we want.

  reply	other threads:[~2016-07-19  4:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-18 18:45 [PATCH v1] ESIA : Dummy eisa_driver_register should return error code Arvind Yadav
2016-07-19  4:31 ` Christoph Hellwig [this message]
2016-07-19 15:50   ` arvind Yadav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160719043152.GA27579@infradead.org \
    --to=hch@infradead.org \
    --cc=arvind.yadav.cs@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox