From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753308AbcGSLr3 (ORCPT ); Tue, 19 Jul 2016 07:47:29 -0400 Received: from mga02.intel.com ([134.134.136.20]:30990 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753124AbcGSLr1 (ORCPT ); Tue, 19 Jul 2016 07:47:27 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,389,1464678000"; d="scan'208";a="1019715629" Date: Tue, 19 Jul 2016 04:48:08 -0700 From: Jacob Pan To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, Thomas Renninger , Peter Zijlstra , Andy Lutomirski , jacob.jun.pan@linux.intel.com Subject: Re: [PATCH resend] intel_rapl: downgrade message if no RAPL domains found in a VM Message-ID: <20160719044808.2a1a42c6@jacob-builder> In-Reply-To: <1468925419-14997-1-git-send-email-pbonzini@redhat.com> References: <1468925419-14997-1-git-send-email-pbonzini@redhat.com> Organization: OTC X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 19 Jul 2016 12:50:19 +0200 Paolo Bonzini wrote: > People complain about the driver saying there's no valid RAPL domains > in a VM, and doing so at KERN_ERR severity. Downgrade this to > KERN_INFO if running on a hypervisor, since it is basically stating > the obvious. > > Suggested-by: Peter Zijlstra > Cc: Jacob Pan > Cc: Andy Lutomirski > Signed-off-by: Paolo Bonzini > --- > First sent out about a year ago. :) > > drivers/powercap/intel_rapl.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/powercap/intel_rapl.c > b/drivers/powercap/intel_rapl.c index b2766b867b0e..0a0b09910116 > 100644 --- a/drivers/powercap/intel_rapl.c > +++ b/drivers/powercap/intel_rapl.c > @@ -1392,7 +1392,9 @@ static int rapl_detect_domains(struct > rapl_package *rp, int cpu) } > rp->nr_domains = bitmap_weight(&rp->domain_map, > RAPL_DOMAIN_MAX); if (!rp->nr_domains) { > - pr_err("no valid rapl domains found in package > %d\n", rp->id); > + printk("%sNo valid RAPL domains found in package > %d\n", > + boot_cpu_has(X86_FEATURE_HYPERVISOR) ? > KERN_INFO : KERN_ERR, > + rp->id); > ret = -ENODEV; > goto done; > } Looks good to me. Please send to Rafael and linux-pm list as well. Thanks, Jacob