From: Wolfram Sang <wsa@the-dreams.de>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
Alison Schofield <amsfield22@gmail.com>,
knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Linux I2C <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH] staging: iio: light: isl29018/28: remove I2C_CLASS_HWMON .class setting
Date: Tue, 19 Jul 2016 09:13:51 +0200 [thread overview]
Message-ID: <20160719071343.GA2086@tetsubishi> (raw)
In-Reply-To: <dff1e871-de49-654f-5e9b-c9b230a35b0a@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 708 bytes --]
On Mon, Jul 18, 2016 at 02:30:46PM +0100, Jonathan Cameron wrote:
> On 18/07/16 09:50, Laxman Dewangan wrote:
> >
> > On Saturday 16 July 2016 07:58 AM, Alison Schofield wrote:
> >> I2C_CLASS_HWMON is for a hardware monitoring chip wanting
> >> auto-detection. IIO drivers don't typically use .class.
> >> Remove it.
> >>
> >> Signed-off-by: Alison Schofield <amsfield22@gmail.com>
> >> Cc: Daniel Baluta <daniel.baluta@gmail.com>
> >>
> >
> > Agree.
> > Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
> Any resulting ABI change from dropping it?
What do you mean with ABI? This is only relevant for "automatic"
instantiation. From me:
Acked-by: Wolfram Sang <wsa@the-dreams.de>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-07-19 7:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-16 2:28 [PATCH] staging: iio: light: isl29018/28: remove I2C_CLASS_HWMON .class setting Alison Schofield
2016-07-18 8:50 ` Laxman Dewangan
2016-07-18 13:30 ` Jonathan Cameron
2016-07-19 7:13 ` Wolfram Sang [this message]
2016-07-20 15:08 ` Jonathan Cameron
2016-07-24 11:30 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160719071343.GA2086@tetsubishi \
--to=wsa@the-dreams.de \
--cc=amsfield22@gmail.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=ldewangan@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox