From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753276AbcGSJwG (ORCPT <rfc822;w@1wt.eu>);
	Tue, 19 Jul 2016 05:52:06 -0400
Received: from mail-wm0-f51.google.com ([74.125.82.51]:35470 "EHLO
	mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752574AbcGSJwE (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 19 Jul 2016 05:52:04 -0400
Date: Tue, 19 Jul 2016 10:51:59 +0100
From: Andy Whitcroft <apw@canonical.com>
To: Joe Perches <joe@perches.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        "Zhuo, Qiuxu" <qiuxu.zhuo@intel.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: Yet another commit id improvement
Message-ID: <20160719095159.GA6746@brain>
References: <fdd22b47463a21c21132edbb8aa35e372950a1e6.1468869915.git.joe@perches.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <fdd22b47463a21c21132edbb8aa35e372950a1e6.1468869915.git.joe@perches.com>
User-Agent: Mutt/1.6.0 (2016-04-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jul 18, 2016 at 12:27:42PM -0700, Joe Perches wrote:
> Using \b isn't good enough to isolate what appears to be a
> commit id in a commit message.
> 
> Make sure there is a space or a quote like character after
> a continuous run of hexadecimal characters that could be
> a commit id.
> 
> Signed-off-by: Joe Perches <joe@perches.com>
> cc: "Zhuo, Qiuxu" <qiuxu.zhuo@intel.com>
> ---
>  scripts/checkpatch.pl | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index a0e5112..8209ae5 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2460,9 +2460,9 @@ sub process {
>  
>  # Check for git id commit length and improperly formed commit descriptions
>  		if ($in_commit_log && !$commit_log_possible_stack_dump &&
> -		    $line !~ /^\s*(?:Link|Patchwork|http|BugLink):/i &&
> +		    $line !~ /^\s*(?:Link|Patchwork|http|https|BugLink):/i &&
>  		    ($line =~ /\bcommit\s+[0-9a-f]{5,}\b/i ||
> -		     ($line =~ /\b[0-9a-f]{12,40}\b/i &&
> +		     ($line =~ /(?:\s|^)[0-9a-f]{12,40}(?:[\s"'\(\[]|$)/i &&

If we expect a quote after would it be unreasonable to allow then at the
beginning too?

>  		      $line !~ /[\<\[][0-9a-f]{12,40}[\>\]]/i &&
>  		      $line !~ /\bfixes:\s*[0-9a-f]{12,40}/i))) {
>  			my $init_char = "c";

-apw