From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753444AbcGSKB2 (ORCPT ); Tue, 19 Jul 2016 06:01:28 -0400 Received: from sci-ig2.spreadtrum.com ([222.66.158.135]:13324 "EHLO SHSQR01.spreadtrum.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1753419AbcGSKBX convert rfc822-to-8bit (ORCPT ); Tue, 19 Jul 2016 06:01:23 -0400 From: "Gaurav Jindal (Gaurav Jindal)" To: Thomas Gleixner CC: "Sanjeev Yadav (Sanjeev Kumar Yadav)" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH]time: Optimize nohz idle enter Thread-Topic: [PATCH]time: Optimize nohz idle enter Thread-Index: AQHR4aRSEIOw94w3jkuM0UCHhRU0wQ== Date: Tue, 19 Jul 2016 10:00:05 +0000 Message-ID: <20160719095957.GA3691@gauravjindalubtnb.del.spreadtrum.com> References: <20160714120416.GB21099@gaurav.jindal@spreadtrum.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.8.1.72] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-MAIL: SHSQR01.spreadtrum.com u6JA0OD4078597 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 19, 2016 at 10:47:37AM +0200, Thomas Gleixner wrote: > On Thu, 14 Jul 2016, Gaurav Jindal (Gaurav Jindal) wrote: > > > > tick_nohz_start_idle is called before checking the condition if the idle tick > > can be stopped. In case when can_stop_idle_tick returns 0, the function called > > is of no use thus a extra call doing nothing. > > > > Shifting calling of function tick_nohz_start_idle inside the if condition makes > > sure that corresponding operations are done only if idle tick can be actually > > stopped. Observance for 1 minute on arm64 architecture shows that shifting code > > can prevent 1.5% of extra calls thus optimizing the idle call sequence. > > Nice. > > > Signed-off-by: gaurav jindal > > Signed-off-by: sanjeev yadav > > This SOB chain is wrong. Sanjeev did not send the patch and is not the > author. Please clarify. > Actually Sanjeev and me worked together, but since only one send the mail so I included his name as SOB. > Thanks, > > tglx -- Regards Gaurav Jindal +91-8800803297