From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752916AbcGSIqn (ORCPT ); Tue, 19 Jul 2016 04:46:43 -0400 Received: from mx2.suse.de ([195.135.220.15]:58845 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752558AbcGSIqk (ORCPT ); Tue, 19 Jul 2016 04:46:40 -0400 Date: Tue, 19 Jul 2016 10:46:29 +0200 From: Jean Delvare To: Paul Gortmaker Cc: , Linus Walleij , Subject: Re: [PATCH] Revert "pinctrl: amd: make it explicitly non-modular" Message-ID: <20160719104629.656ef179@endymion> In-Reply-To: <20160719003030.26420-1-paul.gortmaker@windriver.com> References: <20160719003030.26420-1-paul.gortmaker@windriver.com> Organization: SUSE Linux X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.30; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paul, On Mon, 18 Jul 2016 20:30:30 -0400, Paul Gortmaker wrote: > This reverts commit b8c2b10a9bc0272a20e096852f8fbbf361749dda. > > This patch was in my queue at the same time that a conversion of > the same driver from bool --> tristate was pending and merged. > > That is commit 337ea0fb1535 ("pinctrl: Turn AMD support to tristate") I can't find this commit anywhere, but I would certainly prefer this to making the driver non-modular. So I vote in favor of this revert. Acked-by: Jean Delvare Thanks, -- Jean Delvare SUSE L3 Support