From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754140AbcGSNou (ORCPT ); Tue, 19 Jul 2016 09:44:50 -0400 Received: from mail1.windriver.com ([147.11.146.13]:53078 "EHLO mail1.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753722AbcGSNop (ORCPT ); Tue, 19 Jul 2016 09:44:45 -0400 Date: Tue, 19 Jul 2016 09:44:40 -0400 From: Paul Gortmaker To: Jean Delvare CC: , Linus Walleij , Subject: Re: [PATCH] Revert "pinctrl: amd: make it explicitly non-modular" Message-ID: <20160719134439.GJ21225@windriver.com> References: <20160719003030.26420-1-paul.gortmaker@windriver.com> <20160719104629.656ef179@endymion> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160719104629.656ef179@endymion> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [Re: [PATCH] Revert "pinctrl: amd: make it explicitly non-modular"] On 19/07/2016 (Tue 10:46) Jean Delvare wrote: > Hi Paul, > > On Mon, 18 Jul 2016 20:30:30 -0400, Paul Gortmaker wrote: > > This reverts commit b8c2b10a9bc0272a20e096852f8fbbf361749dda. > > > > This patch was in my queue at the same time that a conversion of > > the same driver from bool --> tristate was pending and merged. > > > > That is commit 337ea0fb1535 ("pinctrl: Turn AMD support to tristate") > > I can't find this commit anywhere, but I would certainly prefer this to > making the driver non-modular. So I vote in favor of this revert. It is a mainline commit, so I guess you need to pull in the last couple months of commits... paul@builder-02:~/git/linux-head$ git describe --contains 337ea0fb1535 v4.6-rc1~149^2~35 paul@builder-02:~/git/linux-head$ git show v4.6-rc1~149 commit 5ca5446ec5ba5e79a6f271cd026bb153d6850fcc Merge: 710d60cbf1b3 3c177a166253 Author: Linus Torvalds Date: Tue Mar 15 20:23:13 2016 -0700 Merge tag 'pinctrl-v4.6-1' of git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl Pull pin control updates from Linus Walleij: I didn't bother marking it for 4.6 stable since it used to be builtin only and even with the crossed patches, it still would have been builtin; it just wouldn't respect the newly available tristate option if chosen. Thanks, Paul. -- > > Acked-by: Jean Delvare > > Thanks, > -- > Jean Delvare > SUSE L3 Support