From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754035AbcGSOUO (ORCPT ); Tue, 19 Jul 2016 10:20:14 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:45633 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753608AbcGSOUL (ORCPT ); Tue, 19 Jul 2016 10:20:11 -0400 Date: Tue, 19 Jul 2016 16:20:09 +0200 From: Andrew Lunn To: Florian Fainelli Cc: Vivien Didelot , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" Subject: Re: [PATCH net-next v3 10/12] net: dsa: support switchdev ageing time attr Message-ID: <20160719142009.GA31103@lunn.ch> References: <20160719004540.1066-1-vivien.didelot@savoirfairelinux.com> <20160719004540.1066-11-vivien.didelot@savoirfairelinux.com> <20160719032415.GD9111@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 18, 2016 at 09:26:00PM -0700, Florian Fainelli wrote: > Le 18/07/2016 à 20:24, Andrew Lunn a écrit : > > On Mon, Jul 18, 2016 at 08:45:38PM -0400, Vivien Didelot wrote: > >> Add a new function for DSA drivers to handle the switchdev > >> SWITCHDEV_ATTR_ID_BRIDGE_AGEING_TIME attribute. > >> > >> The ageing time is passed as milliseconds. > >> > >> Also because we can have multiple logical bridges on top of a physical > >> switch and ageing time are switch-wide, call the driver function with > >> the fastest ageing time in use on the chip instead of the requested one. > >> > >> Signed-off-by: Vivien Didelot > >> --- > >> include/net/dsa.h | 2 ++ > >> net/dsa/slave.c | 41 +++++++++++++++++++++++++++++++++++++++++ > > > > Hi Andrew, > > > Hi Florian > > > > It looks like the SF2 can do fast ageing per port. What i don't see if > > what configuration options you have. Can you get the fast and the > > normal age time per port? Or is it global? > > The normal ageing is global and the value needs to be programmed in > seconds, can can range from 10 to 1,048,575 (encoded on 20 bits). The > fast-ageing can actually be per-port, per-VLAN id, for just dynamic or > static entries etc. and is just a poor name for a flush based on any of > these criteria. Hi Florian So fast ageing does not have a timer value associated to it? It is just a flush? If so, the code Vivien is proposing in DSA slave is O.K. If however there was a per port timer, Vivien's code is too high in the stack, blocking SF2 from being able to use per-port timers. That is what i'm trying to get at. Andrew