From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Alim Akhtar <alim.akhtar@samsung.com>
Cc: rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org,
k.kozlowski@samsung.com, javier@osg.samsung.com,
pankaj.dubey@samsung.com
Subject: Re: [PATCH v2 1/2] rtc: s3c: Remove unnecessary call to disable already disabled clock
Date: Tue, 19 Jul 2016 17:50:02 +0200 [thread overview]
Message-ID: <20160719155002.GK7132@piout.net> (raw)
In-Reply-To: <1467712733-15800-1-git-send-email-alim.akhtar@samsung.com>
On 05/07/2016 at 15:28:52 +0530, Alim Akhtar wrote :
> At the end of s3c_rtc_probe(), s3c_rtc_disable_clk() being called with rtc
> clock already disabled (by s3c_rtc_gettime()), which looks extra and
> unnecessary call. Lets clean it up.
>
> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Reviewed-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> Tested-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> ---
> drivers/rtc/rtc-s3c.c | 2 --
> 1 file changed, 2 deletions(-)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2016-07-19 15:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 9:58 [PATCH v2 1/2] rtc: s3c: Remove unnecessary call to disable already disabled clock Alim Akhtar
2016-07-05 9:58 ` [PATCH v2 2/2] rtc: s3c: Add s3c_rtc_{enable/disable}_clk in s3c_rtc_setfreq() Alim Akhtar
2016-07-19 15:50 ` Alexandre Belloni
2016-07-19 15:50 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160719155002.GK7132@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=alim.akhtar@samsung.com \
--cc=javier@osg.samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pankaj.dubey@samsung.com \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox