From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754084AbcGSPuW (ORCPT ); Tue, 19 Jul 2016 11:50:22 -0400 Received: from down.free-electrons.com ([37.187.137.238]:51825 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753977AbcGSPuQ (ORCPT ); Tue, 19 Jul 2016 11:50:16 -0400 Date: Tue, 19 Jul 2016 17:50:13 +0200 From: Alexandre Belloni To: Alim Akhtar Cc: rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, k.kozlowski@samsung.com, javier@osg.samsung.com, pankaj.dubey@samsung.com, stable@vger.kernel.org Subject: Re: [PATCH v2 2/2] rtc: s3c: Add s3c_rtc_{enable/disable}_clk in s3c_rtc_setfreq() Message-ID: <20160719155013.GL7132@piout.net> References: <1467712733-15800-1-git-send-email-alim.akhtar@samsung.com> <1467712733-15800-2-git-send-email-alim.akhtar@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1467712733-15800-2-git-send-email-alim.akhtar@samsung.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/07/2016 at 15:28:53 +0530, Alim Akhtar wrote : > As per code flow s3c_rtc_setfreq() will get called with rtc clock disabled > and in set_freq we perform h/w registers read/write, which results in a > kernel crash on exynos7 platform while probing rtc driver. > Below is code flow: > s3c_rtc_probe() > clk_prepare_enable(info->rtc_clk) // rtc clock enabled > s3c_rtc_gettime() // will enable clk if not done, and disable it upon exit > s3c_rtc_setfreq() //then this will be called with clk disabled > > This patch take cares of such issue by adding s3c_rtc_{enable/disable}_clk in > s3c_rtc_setfreq(). > > Fixes: 24e1455493da ("drivers/rtc/rtc-s3c.c: delete duplicate clock control") > > Cc: > Signed-off-by: Alim Akhtar > Reviewed-by: Krzysztof Kozlowski > Reviewed-by: Pankaj Dubey > Tested-by: Pankaj Dubey > --- > drivers/rtc/rtc-s3c.c | 2 ++ > 1 file changed, 2 insertions(+) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com