From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752160AbcGSU2r (ORCPT ); Tue, 19 Jul 2016 16:28:47 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:57029 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751742AbcGSU2o (ORCPT ); Tue, 19 Jul 2016 16:28:44 -0400 Date: Tue, 19 Jul 2016 14:28:41 -0600 From: Jason Gunthorpe To: Jarkko Sakkinen Cc: Peter Huewe , linux-security-module@vger.kernel.org, Stefan Berger , open list , "moderated list:TPM DEVICE DRIVER" Subject: Re: [PATCH v3 0/5] Use tpm_transmit_cmd() consistently across kernel call sites Message-ID: <20160719202841.GC16042@obsidianresearch.com> References: <1468935171-7815-1-git-send-email-jarkko.sakkinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1468935171-7815-1-git-send-email-jarkko.sakkinen@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.151 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 19, 2016 at 04:32:44PM +0300, Jarkko Sakkinen wrote: > These commits update the subsystem consistently to use > tpm_transmit_cmd() throughout the subsystem the exception being > tpm_write() where it makes sense to use the raw interface because higher > level command handling is delegated to user space. The point is to make > semantics and error handling across the kernel call sites. > > v3: Removed patch that renames tpm_pcr_read_dev() to tpm1_pcr_read() > because it is not mandatory for this patch set. > > v2: Added commit that drops externs from all function declarations in > tpm.h as suggested by Jason Gunthorpe. Other than my comment: Reviewed-by: Jason Gunthorpe Jason