From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751367AbcGTEOn (ORCPT ); Wed, 20 Jul 2016 00:14:43 -0400 Received: from mail1.windriver.com ([147.11.146.13]:34669 "EHLO mail1.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751091AbcGTEOe (ORCPT ); Wed, 20 Jul 2016 00:14:34 -0400 From: Paul Gortmaker To: CC: Paul Gortmaker , Alexandre Courbot , Daniel Mack , Haojian Zhuang , Linus Walleij , , , , Robert Jarzmik , Russell King , Tony Lindgren Subject: [PATCH 0/3] ARM: fix three implicit module use cases fed via gpio Date: Wed, 20 Jul 2016 00:13:29 -0400 Message-ID: <20160720041332.30789-1-paul.gortmaker@windriver.com> X-Mailer: git-send-email 2.8.4 MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org While working on some for-4.9 cleanups of linux/gpio/driver.h it was found that changes there caused build failures when walking all the ARM defconfigs, in ARM specific mach-* files. The proposed GPIO header change is just this: --------------------------------------- --- a/include/linux/gpio/driver.h +++ b/include/linux/gpio/driver.h @@ -3,7 +3,6 @@ #include #include -#include #include #include #include @@ -16,6 +15,7 @@ struct of_phandle_args; struct device_node; struct seq_file; struct gpio_device; +struct module; #ifdef CONFIG_GPIOLIB --------------------------------------- ...which is what we've already got in ~50 other include/linux/* files to try and keep cross contamination entanglement at a minimum. So we uncovered three users in ARM specific files relying on the above presence in this header, vs. dealing with it within the driver itself. But with ARM and GPIO being different subsystems, we'll need to get this in ARM 1st, and then wait a release before changing the GPIO header, otherwise we'll risk triggering these three build failures. So, if folks consider these three trivial changes OK for late in the for-4.8 cycle, then great. Otherwise I'll resubmit the ARM parts for for-4.9 and the GPIO bits for the one after that. [Yes, there were gpio implicit users too, but they are easily sync'd with the gpio header change being at the end of that series.] Paul. -- Cc: Alexandre Courbot Cc: Daniel Mack Cc: Haojian Zhuang Cc: Linus Walleij Cc: linux-arm-kernel@lists.infradead.org Cc: linux-gpio@vger.kernel.org Cc: linux-omap@vger.kernel.org Cc: Robert Jarzmik Cc: Russell King Cc: Tony Lindgren Paul Gortmaker (3): ARM: mach-omap2: remove bogus "or_module" from rx51-peripherals ARM: pxa: add module.h for corgi symbol_get/symbol_put usage ARM: pxa: add module.h for spitz symbol_get/symbol_put usage arch/arm/mach-omap2/board-rx51-peripherals.c | 2 +- arch/arm/mach-pxa/corgi.c | 1 + arch/arm/mach-pxa/spitz.c | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) -- 2.8.4