From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752192AbcGTGsz (ORCPT ); Wed, 20 Jul 2016 02:48:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54588 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751220AbcGTGsy (ORCPT ); Wed, 20 Jul 2016 02:48:54 -0400 Date: Wed, 20 Jul 2016 14:48:50 +0800 From: "bhe@redhat.com" To: Thomas Gleixner Cc: "fenghua.yu@intel.com" , "x86@kernel.org" , "kexec@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "mingo@redhat.com" , "ebiederm@xmission.com" , "hpa@zytor.com" , "Wei, Jiangang" , "vgoyal@redhat.com" Subject: Re: [PATCH 0/3] Enable legacy irq mode before jump to kexec/kdump kernel Message-ID: <20160720064850.GC2608@x1.redhat.com> References: <1468983483-3952-1-git-send-email-bhe@redhat.com> <1468986741.2020.41.camel@localhost> <20160720041527.GA5273@x1.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 20 Jul 2016 06:48:53 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/20/16 at 08:32am, Thomas Gleixner wrote: > On Wed, 20 Jul 2016, bhe@redhat.com wrote: > > On 07/20/16 at 03:54am, Wei, Jiangang wrote: > > > > > In fact, Eric and Ingo suggested that "it should be fixed in the bootup > > > path of the dump kernel, not the crash kernel reboot path", which is > > > convincing and reasonable. > > > > Well this patch doesn't do differently with Eric's original implemention > > in kexec/kdump path. > > By taking out clear_IO_APIC from disable_IO_APIC, the left code of > > disable_IO_APIC will only do the virtual wire setting. So for > > kexec/kdump path, code basically is the same as Eric's method. But for > > poweroff/halt/reboot, it's enough to call clear_IO_APIC to disable > > IO-APIC. > > You're completely ignoring what Jiangang said: > > "it should be fixed in the bootup path of the dump kernel, not the crash > kernel reboot path" > > and that's the right way to do it. End of story. Thanks, tglx. What I did is like reverting commit 522e6646446. But it would be great if we can change to fix it in bootup path. Thanks Baoquan