From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753286AbcGTIWj (ORCPT ); Wed, 20 Jul 2016 04:22:39 -0400 Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:58103 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753050AbcGTIWh (ORCPT ); Wed, 20 Jul 2016 04:22:37 -0400 Authentication-Results: ppops.net; spf=none smtp.mailfrom=ckeepax@opensource.wolfsonmicro.com Date: Wed, 20 Jul 2016 09:22:42 +0100 From: Charles Keepax To: Chanwoo Choi CC: , , Subject: Re: [PATCH 1/4] extcon: arizona: Remove the usage of extcon_update_state() Message-ID: <20160720082242.GA8680@localhost.localdomain> References: <1469000327-15615-1-git-send-email-cw00.choi@samsung.com> <1469000327-15615-2-git-send-email-cw00.choi@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1469000327-15615-2-git-send-email-cw00.choi@samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1607200097 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 20, 2016 at 04:38:44PM +0900, Chanwoo Choi wrote: > This patch remvoes the usage of extcon_update_state() because > the extcon_update_state() use directly the bit masking calculation > to change the state of external connector without the unique id of > external connector. It makes the code diffcult to read it. > So, this patch uses the extcon_set_cable_state_() instead. > > Cc: Charles Keepax > Cc: patches@opensource.wolfsonmicro.com > Signed-off-by: Chanwoo Choi > --- Acked-by: Charles Keepax Thanks, Charles