From: Tejun Heo <tj@kernel.org>
To: Aleksa Sarai <asarai@suse.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Li Zefan <lizefan@huawei.com>,
Johannes Weiner <hannes@cmpxchg.org>,
"Serge E. Hallyn" <serge.hallyn@ubuntu.com>,
Aditya Kali <adityakali@google.com>,
Chris Wilson <chris@chris-wilson.co.uk>,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
Christian Brauner <cbrauner@suse.de>,
dev@opencontainers.org
Subject: Re: [PATCH v1 2/3] cgroup: allow for unprivileged subtree management
Date: Wed, 20 Jul 2016 11:45:57 -0400 [thread overview]
Message-ID: <20160720154557.GF4574@htj.duckdns.org> (raw)
In-Reply-To: <20160718161816.13040-3-asarai@suse.de>
Hello, Aleksa.
On Tue, Jul 19, 2016 at 02:18:15AM +1000, Aleksa Sarai wrote:
> +static int cgroup_permission(struct inode *inode, struct kernfs_node *kn,
> + int mask)
> +{
> + int ret;
> + struct cgroup *cgroup;
> + struct cgroup_namespace *cgroupns;
> +
> + /*
> + * First, compute the generic_permission return value. In most cases
> + * this will succeed and we can also avoid duplicating this code.
> + */
> +
> + cgroup = kn->priv;
> + cgroup_get(cgroup);
This pattern which is repated for cgroupns doesn't make sense. The
code is already assuming that the cgroup is safe to deref. Getting
its reference doesn't do anything. Getting it here would only make
sense if the pointer is passed to an asynchronous context.
Thanks.
--
tejun
next prev parent reply other threads:[~2016-07-20 15:46 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-18 16:18 [PATCH v1 0/3] cgroup: allow for unprivileged management Aleksa Sarai
2016-07-18 16:18 ` [PATCH v1 1/3] kernfs: add support for custom per-sb permission hooks Aleksa Sarai
2016-07-18 16:18 ` [PATCH v1 2/3] cgroup: allow for unprivileged subtree management Aleksa Sarai
2016-07-20 15:45 ` Tejun Heo [this message]
2016-07-20 22:59 ` Aleksa Sarai
2016-07-18 16:18 ` [PATCH v1 3/3] cgroup: relax common ancestor restriction for direct descendants Aleksa Sarai
2016-07-20 15:51 ` Tejun Heo
2016-07-20 22:58 ` Aleksa Sarai
2016-07-20 23:02 ` Tejun Heo
2016-07-20 23:18 ` Aleksa Sarai
2016-07-20 23:19 ` Tejun Heo
2016-07-21 7:49 ` Aleksa Sarai
2016-07-21 14:33 ` Serge E. Hallyn
2016-07-21 14:37 ` Aleksa Sarai
2016-07-21 15:01 ` Tejun Heo
2016-07-21 15:09 ` Serge E. Hallyn
2016-07-21 14:51 ` James Bottomley
2016-07-21 14:59 ` Tejun Heo
2016-07-21 15:07 ` Aleksa Sarai
2016-07-21 15:04 ` Tejun Heo
2016-07-21 14:52 ` Tejun Heo
2016-07-21 15:04 ` James Bottomley
2016-07-21 15:07 ` Tejun Heo
2016-07-21 15:16 ` James Bottomley
2016-07-21 15:26 ` Tejun Heo
2016-07-21 15:34 ` James Bottomley
2016-07-21 15:50 ` Tejun Heo
2016-07-21 18:16 ` James Bottomley
2016-07-21 21:06 ` Tejun Heo
2016-07-22 8:30 ` Aleksa Sarai
2016-07-25 18:38 ` Tejun Heo
2016-07-25 22:54 ` Serge E. Hallyn
2016-07-22 8:24 ` Aleksa Sarai
2016-07-25 18:44 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160720154557.GF4574@htj.duckdns.org \
--to=tj@kernel.org \
--cc=adityakali@google.com \
--cc=asarai@suse.de \
--cc=cbrauner@suse.de \
--cc=cgroups@vger.kernel.org \
--cc=chris@chris-wilson.co.uk \
--cc=dev@opencontainers.org \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=serge.hallyn@ubuntu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox