From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753686AbcGTTc7 (ORCPT ); Wed, 20 Jul 2016 15:32:59 -0400 Received: from down.free-electrons.com ([37.187.137.238]:59030 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752722AbcGTTc4 (ORCPT ); Wed, 20 Jul 2016 15:32:56 -0400 Date: Wed, 20 Jul 2016 21:32:53 +0200 From: Alexandre Belloni To: Arnaud Ebalard , Rob Herring Cc: Alessandro Zummo , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] Documentation: dt: Intersil isl12057 is not a trivial device Message-ID: <20160720193253.GB4446@piout.net> References: <1468371571-22641-1-git-send-email-alexandre.belloni@free-electrons.com> <1468371571-22641-2-git-send-email-alexandre.belloni@free-electrons.com> <87zipkgeuv.fsf@natisbad.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87zipkgeuv.fsf@natisbad.org> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +robh On 14/07/2016 at 22:10:48 +0200, Arnaud Ebalard wrote : > Alexandre Belloni writes: > > > The ISL12057 has a documentation file, remove it from trivial-devices.txt > > > > Signed-off-by: Alexandre Belloni > > --- > > Documentation/devicetree/bindings/i2c/trivial-devices.txt | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c/trivial-devices.txt > > index 539874490492..a397d39ea741 100644 > > --- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt > > +++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt > > @@ -50,7 +50,6 @@ fsl,sgtl5000 SGTL5000: Ultra Low-Power Audio Codec > > gmt,g751 G751: Digital Temperature Sensor and Thermal Watchdog with Two-Wire Interface > > infineon,slb9635tt Infineon SLB9635 (Soft-) I2C TPM (old protocol, max 100khz) > > infineon,slb9645tt Infineon SLB9645 I2C TPM (new protocol, max 400khz) > > -isil,isl12057 Intersil ISL12057 I2C RTC Chip > > isil,isl29028 Intersil ISL29028 Ambient Light and Proximity Sensor > > maxim,ds1050 5 Bit Programmable, Pulse-Width Modulator > > maxim,max1237 Low-Power, 4-/12-Channel, 2-Wire Serial, 12-Bit ADCs > > No strong advice on this but I thought it qualified as a trivial device > because it did not *need* anything else except a compatible, an address > and possibly an interrupt. The additional boolean property documented in > Documentation/devicetree/bindings/rtc/isil,isl12057.txt is optional. > Well, my thinking is that trivial devices are in trivial-devices.txt because they are not documented anywhere else. This is mostly the case. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com