From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755252AbcGTUyT (ORCPT ); Wed, 20 Jul 2016 16:54:19 -0400 Received: from mga02.intel.com ([134.134.136.20]:32470 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755029AbcGTUyQ (ORCPT ); Wed, 20 Jul 2016 16:54:16 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,396,1464678000"; d="scan'208";a="999316701" Date: Wed, 20 Jul 2016 23:54:10 +0300 From: Jarkko Sakkinen To: Jason Gunthorpe Cc: Peter Huewe , linux-security-module@vger.kernel.org, Stefan Berger , Marcel Selhorst , "moderated list:TPM DEVICE DRIVER" , open list Subject: Re: [PATCH v4 3/5] tpm: replace tpm_gen_interrupt() with tpm_tis_gen_interrupt() Message-ID: <20160720205410.GB6525@intel.com> References: <1468971906-6528-1-git-send-email-jarkko.sakkinen@linux.intel.com> <1468971906-6528-4-git-send-email-jarkko.sakkinen@linux.intel.com> <20160720170624.GE21460@obsidianresearch.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160720170624.GE21460@obsidianresearch.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 20, 2016 at 11:06:24AM -0600, Jason Gunthorpe wrote: > On Wed, Jul 20, 2016 at 02:44:58AM +0300, Jarkko Sakkinen wrote: > > Since tpm_gen_interrupt() is only used in tpm_tis_core.c this commit > > replaces it with an internal tpm_tis_gen_interrupt(). The semantics > > also changed in a way that on a system error the driver initialization > > is failed. > > All the patches look good to me now.. > > Reviewed-by: Jason Gunthorpe Thanks. /Jarkko