From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751450AbcGUIIn (ORCPT ); Thu, 21 Jul 2016 04:08:43 -0400 Received: from outbound-smtp04.blacknight.com ([81.17.249.35]:46879 "EHLO outbound-smtp04.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751455AbcGUII2 (ORCPT ); Thu, 21 Jul 2016 04:08:28 -0400 Date: Thu, 21 Jul 2016 09:08:24 +0100 From: Mel Gorman To: Minchan Kim Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Vlastimil Babka , Linux-MM , LKML Subject: Re: [PATCH 5/5] mm: consider per-zone inactive ratio to deactivate Message-ID: <20160721080824.GE10438@techsingularity.net> References: <1469028111-1622-1-git-send-email-mgorman@techsingularity.net> <1469028111-1622-6-git-send-email-mgorman@techsingularity.net> <20160721053017.GB31865@bbox> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20160721053017.GB31865@bbox> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 21, 2016 at 02:30:17PM +0900, Minchan Kim wrote: > > The problem is due to the active deactivation logic in inactive_list_is_low. > > > > Node 0 active_anon:404412kB inactive_anon:409040kB > > > > IOW, (inactive_anon of node * inactive_ratio > active_anon of node) due to > > highmem anonymous stat so VM never deactivates normal zone's anonymous pages. > > > > This patch is a modified version of Minchan's original solution but based > > upon it. The problem with Minchan's patch is that it didn't take memcg > > into account and any low zone with an imbalanced list could force a rotation. > > Could you explan why we should consider memcg here? > It already was and there is no good reason to ignore it if it's memcg reclaim. > > In this page, a zone-constrained global reclaim will rotate the list if > > patch, > I'll fix it. -- Mel Gorman SUSE Labs