From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752710AbcGUOgs (ORCPT ); Thu, 21 Jul 2016 10:36:48 -0400 Received: from foss.arm.com ([217.140.101.70]:48511 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751726AbcGUOgq (ORCPT ); Thu, 21 Jul 2016 10:36:46 -0400 Date: Thu, 21 Jul 2016 15:36:45 +0100 From: Juri Lelli To: xlpang@redhat.com Cc: peterz@infradead.org, rostedt@goodmis.org, linux-kernel@vger.kernel.org, mingo@redhat.com, luca.abeni@unitn.it Subject: Re: [PATCH v4] sched/deadline: remove useless param from setup_new_dl_entity Message-ID: <20160721143645.GI30584@e106622-lin> References: <1468407489-30476-1-git-send-email-juri.lelli@arm.com> <5788BD67.5050509@redhat.com> <20160718130441.GH30141@e106622-lin> <578CDB83.1030702@redhat.com> <20160721142106.GH30584@e106622-lin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160721142106.GH30584@e106622-lin> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/07/16 15:21, Juri Lelli wrote: > Hi, > > On 18/07/16 21:37, Xunlei Pang wrote: > > On 2016/07/18 at 21:04, Juri Lelli wrote: > > > On 15/07/16 18:39, Xunlei Pang wrote: > > >> On 2016/07/13 at 18:58, Juri Lelli wrote: > > > [...] > > > > > >> Since this is only called for queued cases now, there is no need to > > >> check boosted stuff here. As enqueue_task(ENQUEUE_REPLENISH) > > >> is called before check_class_changed() in rt_mutex_setprio(). > > >> > > > But we don't do the same in setscheduler, right? > > > > If p is deadline PI-boosted, setscheduler() won't call change its sched_class. > > If p isn't deadline PI-boosted, then pi_task is NULL. > > > > So, I think the added code won't hit. Did I miss something? > > > > No, I think you are right. > Oh, and we need to filter the call after rt_mutex_setprio has already issued a replenishment. > I'll shoot a v5 ASAP (I think I'll put a WARN_ON just in case). > > Best, > > - Juri >