[PATCH] crypto: x86/glue_helper make bool

[PATCH] crypto: x86/glue_helper make bool

[Luis R. Rodriguez]

Paul's changes to remove MODULE_LICENSE() out of the x86 glue_helper
causes a kernel with CONFIG_CRYPTO_GLUE_HELPER_X86=m to taint since
it now detects the license is missing if you try to build the driver
as a module, log below.

Fix this by removing the module option for it via Kconfig as it
cannot be a module.

glue_helper: module license 'unspecified' taints kernel.
glue_helper: module license 'unspecified' taints kernel.
Disabling lock debugging due to kernel taint
glue_helper: Unknown symbol blkcipher_walk_done (err 0)
glue_helper: Unknown symbol blkcipher_walk_virt (err 0)
glue_helper: Unknown symbol kernel_fpu_end (err 0)
glue_helper: Unknown symbol kernel_fpu_begin (err 0)
glue_helper: Unknown symbol blkcipher_walk_virt_block (err 0)
glue_helper: Unknown symbol blkcipher_walk_done (err 0)
glue_helper: Unknown symbol blkcipher_walk_virt (err 0)
glue_helper: Unknown symbol kernel_fpu_end (err 0)
glue_helper: Unknown symbol kernel_fpu_begin (err 0)
glue_helper: Unknown symbol blkcipher_walk_virt_block (err 0)
glue_helper: Unknown symbol blkcipher_walk_done (err 0)
glue_helper: Unknown symbol blkcipher_walk_virt (err 0)
glue_helper: Unknown symbol kernel_fpu_end (err 0)
glue_helper: Unknown symbol kernel_fpu_begin (err 0)
glue_helper: Unknown symbol blkcipher_walk_virt_block (err 0)
glue_helper: Unknown symbol blkcipher_walk_done (err 0)
glue_helper: Unknown symbol blkcipher_walk_virt (err 0)
glue_helper: Unknown symbol kernel_fpu_end (err 0)
glue_helper: Unknown symbol kernel_fpu_begin (err 0)
glue_helper: Unknown symbol blkcipher_walk_virt_block (err 0)

Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
---
 crypto/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/crypto/Kconfig b/crypto/Kconfig
index a9377bef25e3..ed6abf4bbf3b 100644
--- a/crypto/Kconfig
+++ b/crypto/Kconfig
@@ -237,7 +237,7 @@ config CRYPTO_ABLK_HELPER
 	select CRYPTO_CRYPTD
 
 config CRYPTO_GLUE_HELPER_X86
-	tristate
+	bool
 	depends on X86
 	select CRYPTO_ALGAPI
 
-- 
2.8.4

Re: [PATCH] crypto: x86/glue_helper make bool

[Paul Gortmaker]

[[PATCH] crypto: x86/glue_helper make bool] On 21/07/2016 (Thu 15:13) Luis R. Rodriguez wrote:

> Paul's changes to remove MODULE_LICENSE() out of the x86 glue_helper
> causes a kernel with CONFIG_CRYPTO_GLUE_HELPER_X86=m to taint since
> it now detects the license is missing if you try to build the driver
> as a module, log below.

Reported and fixed two days ago ; the fix went out in yesterday's
linux-next via the tip tree.

https://lkml.kernel.org/r/20160719144243.GK21225@windriver.com

I fixed it by restoring the license, since making it bool might break
existing use cases, and my intent of this audit was to get rid of stuff
without altering runtime at all.

Thanks,
Paul.
--

> 
> Fix this by removing the module option for it via Kconfig as it
> cannot be a module.
> 
> glue_helper: module license 'unspecified' taints kernel.
> glue_helper: module license 'unspecified' taints kernel.
> Disabling lock debugging due to kernel taint
> glue_helper: Unknown symbol blkcipher_walk_done (err 0)
> glue_helper: Unknown symbol blkcipher_walk_virt (err 0)
> glue_helper: Unknown symbol kernel_fpu_end (err 0)
> glue_helper: Unknown symbol kernel_fpu_begin (err 0)
> glue_helper: Unknown symbol blkcipher_walk_virt_block (err 0)
> glue_helper: Unknown symbol blkcipher_walk_done (err 0)
> glue_helper: Unknown symbol blkcipher_walk_virt (err 0)
> glue_helper: Unknown symbol kernel_fpu_end (err 0)
> glue_helper: Unknown symbol kernel_fpu_begin (err 0)
> glue_helper: Unknown symbol blkcipher_walk_virt_block (err 0)
> glue_helper: Unknown symbol blkcipher_walk_done (err 0)
> glue_helper: Unknown symbol blkcipher_walk_virt (err 0)
> glue_helper: Unknown symbol kernel_fpu_end (err 0)
> glue_helper: Unknown symbol kernel_fpu_begin (err 0)
> glue_helper: Unknown symbol blkcipher_walk_virt_block (err 0)
> glue_helper: Unknown symbol blkcipher_walk_done (err 0)
> glue_helper: Unknown symbol blkcipher_walk_virt (err 0)
> glue_helper: Unknown symbol kernel_fpu_end (err 0)
> glue_helper: Unknown symbol kernel_fpu_begin (err 0)
> glue_helper: Unknown symbol blkcipher_walk_virt_block (err 0)
> 
> Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
> ---
>  crypto/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/crypto/Kconfig b/crypto/Kconfig
> index a9377bef25e3..ed6abf4bbf3b 100644
> --- a/crypto/Kconfig
> +++ b/crypto/Kconfig
> @@ -237,7 +237,7 @@ config CRYPTO_ABLK_HELPER
>  	select CRYPTO_CRYPTD
>  
>  config CRYPTO_GLUE_HELPER_X86
> -	tristate
> +	bool
>  	depends on X86
>  	select CRYPTO_ALGAPI
>  
> -- 
> 2.8.4
> 

Re: [PATCH] crypto: x86/glue_helper make bool

[Luis R. Rodriguez]

On Thu, Jul 21, 2016 at 07:01:11PM -0400, Paul Gortmaker wrote:
> [[PATCH] crypto: x86/glue_helper make bool] On 21/07/2016 (Thu 15:13) Luis R. Rodriguez wrote:
> 
> > Paul's changes to remove MODULE_LICENSE() out of the x86 glue_helper
> > causes a kernel with CONFIG_CRYPTO_GLUE_HELPER_X86=m to taint since
> > it now detects the license is missing if you try to build the driver
> > as a module, log below.
> 
> Reported and fixed two days ago ; the fix went out in yesterday's
> linux-next via the tip tree.
> 
> https://lkml.kernel.org/r/20160719144243.GK21225@windriver.com
> 
> I fixed it by restoring the license, since making it bool might break
> existing use cases,

How so?

  Luis

Re: [PATCH] crypto: x86/glue_helper make bool

[Paul Gortmaker]

[Re: [PATCH] crypto: x86/glue_helper make bool] On 22/07/2016 (Fri 01:06) Luis R. Rodriguez wrote:

> On Thu, Jul 21, 2016 at 07:01:11PM -0400, Paul Gortmaker wrote:
> > [[PATCH] crypto: x86/glue_helper make bool] On 21/07/2016 (Thu 15:13) Luis R. Rodriguez wrote:
> > 
> > > Paul's changes to remove MODULE_LICENSE() out of the x86 glue_helper
> > > causes a kernel with CONFIG_CRYPTO_GLUE_HELPER_X86=m to taint since
> > > it now detects the license is missing if you try to build the driver
> > > as a module, log below.
> > 
> > Reported and fixed two days ago ; the fix went out in yesterday's
> > linux-next via the tip tree.
> > 
> > https://lkml.kernel.org/r/20160719144243.GK21225@windriver.com
> > 
> > I fixed it by restoring the license, since making it bool might break
> > existing use cases,
> 
> How so?

In the now deleted text, you wrote:

      Fix this by removing the module option for it via Kconfig as it
      cannot be a module.

      glue_helper: module license 'unspecified' taints kernel.

The 2nd line of output clearly contradicts your 1st line stating it
cannot be a module.   It clearly was a module, and loaded, and tainted
the kernel because it had no license.

As for use cases, there can be many that could break. Someone with a
kernel that just fit in flash, now ends up with glue_helper builtin, and
their kernel won't fit anymore.

Or someone has a script that manually ran "modprobe glue_helper" at
startup along with other specifically chosen modules.  Now that step
will fail.

As I said, I don't want to be introducing runtime changes in an audit
for unnecessary module.h instances.

Paul.
--
> 
>   Luis