From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753925AbcGVK47 (ORCPT ); Fri, 22 Jul 2016 06:56:59 -0400 Received: from foss.arm.com ([217.140.101.70]:52485 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753329AbcGVK45 (ORCPT ); Fri, 22 Jul 2016 06:56:57 -0400 Date: Fri, 22 Jul 2016 11:56:49 +0100 From: Mark Rutland To: Tan Xiaojun Cc: robh+dt@kernel.org, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, xuwei5@hisilicon.com, devicetree@vger.kernel.org, khilman@linaro.org, k.kozlowski@samsung.com, amitdanielk@gmail.com, heiko@sntech.de, wxt@rock-chips.com, alex.aring@gmail.com, qiang.zhao@freescale.com, treding@nvidia.com, rmk+kernel@arm.linux.org.uk, gregory.clement@free-electrons.com, f.fainelli@gmail.com, geert+renesas@glider.be, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [RFC PATCH v1 0/2] Add Hisilicon Djtag driver Message-ID: <20160722105648.GD17584@leverpostej> References: <1469177332-72156-1-git-send-email-tanxiaojun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1469177332-72156-1-git-send-email-tanxiaojun@huawei.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, I understand that some SoC/socket level PMU is accessed via these registers. It doesn't make sense to review either in isolation. Please put together a unified series, with both the djtag accessors and the PMU code. On it's own, it's *very* difficult to understand how this fits into the SoC, and how it is to be used. Thanks, Mark. On Fri, Jul 22, 2016 at 04:48:50PM +0800, Tan Xiaojun wrote: > > Tan Xiaojun (2): > Documentation: arm64: Add Hisilicon HiP05/06/07 Sysctrl and Djtag dts > bindings > drivers: soc: Add support for Hisilicon Djtag driver > > .../bindings/arm/hisilicon/hisilicon.txt | 98 +++++ > drivers/soc/Kconfig | 1 + > drivers/soc/Makefile | 1 + > drivers/soc/hisilicon/Kconfig | 12 + > drivers/soc/hisilicon/Makefile | 1 + > drivers/soc/hisilicon/djtag.c | 373 ++++++++++++++++++++ > include/linux/soc/hisilicon/djtag.h | 18 + > 7 files changed, 504 insertions(+) > create mode 100644 drivers/soc/hisilicon/Kconfig > create mode 100644 drivers/soc/hisilicon/Makefile > create mode 100644 drivers/soc/hisilicon/djtag.c > create mode 100644 include/linux/soc/hisilicon/djtag.h > > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >