From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752050AbcGXGfh (ORCPT ); Sun, 24 Jul 2016 02:35:37 -0400 Received: from mga09.intel.com ([134.134.136.24]:19093 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751268AbcGXGff (ORCPT ); Sun, 24 Jul 2016 02:35:35 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,412,1464678000"; d="scan'208";a="738884186" Date: Sun, 24 Jul 2016 12:12:56 +0530 From: Vinod Koul To: Sinan Kaya Cc: "dmaengine@vger.kernel.org" , "timur@codeaurora.org" , "devicetree@vger.kernel.org" , "cov@codeaurora.org" , "jcm@redhat.com" , "eric.auger@linaro.org" , "agross@codeaurora.org" , "arnd@arndb.de" , "linux-arm-msm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "Williams, Dan J" , Andy Shevchenko , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 10/10] dmaengine: qcom_hidma: add MSI support for interrupts Message-ID: <20160724064256.GA9681@localhost> References: <1468867177-15007-1-git-send-email-okaya@codeaurora.org> <1468867177-15007-11-git-send-email-okaya@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1468867177-15007-11-git-send-email-okaya@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 19, 2016 at 12:09:37AM +0530, Sinan Kaya wrote: > @@ -567,6 +578,98 @@ static int hidma_create_sysfs_entry(struct hidma_dev *dev, char *name, > return device_create_file(dev->ddev.dev, attrs); > } > > +#ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN This can be true on machine with your older HW, so I would be bit more careful here.. > + if (rc) > + dev_warn(&pdev->dev, > + "failed to request MSI irq, falling back to wired IRQ\n"); > + return rc; > +#else > + return -EINVAL; -EINVAL doesnt sound apt here.. > + struct acpi_device *adev = ACPI_COMPANION(dev); > + const char *of_compat; > + int ret; > + > + if (!adev || acpi_disabled) { > + ret = device_property_read_string(dev, "compatible", > + &of_compat); > + if (ret) > + return false; > + > + ret = strcmp(of_compat, "qcom,hidma-1.1"); > + } else { > + ret = strcmp(acpi_device_hid(adev), "QCOM8062"); Okay if you ahve a device ID then why do we need new binding? This device as you said implies the support for MSI interrupts. Thanks -- ~Vinod