From: Vinod Koul <vinod.koul@intel.com>
To: John Stultz <john.stultz@linaro.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
Andy Green <andy.green@linaro.org>,
Zhangfei Gao <zhangfei.gao@linaro.org>,
Jingoo Han <jg1.han@samsung.com>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Dan Williams <dan.j.williams@intel.com>,
Mark Brown <broonie@kernel.org>, Andy Green <andy@warmcat.com>
Subject: Re: [PATCH 4/7] k3dma: Add cyclic mode for audio
Date: Sun, 24 Jul 2016 13:01:09 +0530 [thread overview]
Message-ID: <20160724073108.GD9681@localhost> (raw)
In-Reply-To: <1469073189-9167-5-git-send-email-john.stultz@linaro.org>
On Wed, Jul 20, 2016 at 08:53:06PM -0700, John Stultz wrote:
> ds = kzalloc(sizeof(*ds) + num * sizeof(ds->desc_hw[0]), GFP_ATOMIC);
> - if (!ds) {
> - dev_dbg(chan->device->dev, "vchan %p: kzalloc fail\n", &c->vc);
> + if (!ds)
This is an unrelated change
> +
> + ds = kzalloc(sizeof(*ds) + num * sizeof(ds->desc_hw[0]), GFP_ATOMIC);
we should use GFP_NOWAIT. And looks like driver doesn't use GFP_NOWAIT< so
you may fix that up as well
> + if (!ds)
> + return NULL;
> +
> + ds->desc_hw_lli = __virt_to_phys((unsigned long)&ds->desc_hw[0]);
why no dma_map_single(()?
Also __api is internal APIs, driver should not use them. Why not plain
virt_to_phys()
--
~Vinod
next prev parent reply other threads:[~2016-07-24 7:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 3:53 [PATCH 0/7 v3] K3DMA fixes for HiKey HDMI audio John Stultz
2016-07-21 3:53 ` [PATCH 1/7] k3dma: Fix hisi burst clipping John Stultz
2016-07-24 7:25 ` Vinod Koul
2016-07-29 22:40 ` John Stultz
2016-08-04 13:08 ` Vinod Koul
2016-08-04 17:36 ` John Stultz
2016-08-05 3:36 ` Vinod Koul
2016-07-21 3:53 ` [PATCH 2/7] k3dma: Fix dma err offsets John Stultz
2016-07-21 3:53 ` [PATCH 3/7] k3dma: Fix "nobody cared" message seen on any error John Stultz
2016-07-21 3:53 ` [PATCH 4/7] k3dma: Add cyclic mode for audio John Stultz
2016-07-24 7:31 ` Vinod Koul [this message]
2016-07-29 22:38 ` John Stultz
2016-07-21 3:53 ` [PATCH 5/7] k3dma: Fix memory handling with cyclic mode John Stultz
2016-07-21 3:53 ` [PATCH 6/7] k3dma: Fix occasional DMA ERR issue by using proper dma api John Stultz
2016-07-21 4:26 ` zhangfei
2016-07-21 5:22 ` John Stultz
2016-07-21 6:27 ` Andy Green
2016-07-21 10:40 ` Mark Brown
2016-07-21 13:12 ` Andy Green
2016-07-21 16:18 ` John Stultz
2016-07-21 19:57 ` Andy Green
2016-07-21 16:08 ` zhangfei
2016-07-21 3:53 ` [PATCH 7/7] Kconfig: Allow k3dma driver to be selected for more then HISI3xx platforms John Stultz
2016-07-22 6:56 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160724073108.GD9681@localhost \
--to=vinod.koul@intel.com \
--cc=andy.green@linaro.org \
--cc=andy@warmcat.com \
--cc=broonie@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=jg1.han@samsung.com \
--cc=john.stultz@linaro.org \
--cc=k.kozlowski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).